Skip to content
Permalink
Browse files

Don't send a resize event if the window size didn't change

  • Loading branch information...
sethfowler committed Jun 28, 2013
1 parent 677fce2 commit 72f5e5f30d52673dddb3b5e76333e122eef00a42
Showing with 9 additions and 4 deletions.
  1. +8 −3 src/components/main/compositing/mod.rs
  2. +1 −1 src/components/script/script_task.rs
@@ -182,9 +182,14 @@ impl CompositorTask {
let layout_chan_clone = layout_chan.clone();
// Hook the windowing system's resize callback up to the resize rate limiter.
do window.set_resize_callback |width, height| {
debug!("osmain: window resized to %ux%u", width, height);
*window_size = Size2D(width as int, height as int);
layout_chan_clone.chan.send(RouteScriptMsg(SendEventMsg(ResizeEvent(width, height))));
let new_size = Size2D(width as int, height as int);
if *window_size != new_size {
debug!("osmain: window resized to %ux%u", width, height);
*window_size = new_size;
layout_chan_clone.chan.send(RouteScriptMsg(SendEventMsg(ResizeEvent(width, height))));
} else {
debug!("osmain: dropping window resize since size is still %ux%u", width, height);
}
}

let layout_chan_clone = layout_chan.clone();
@@ -440,7 +440,7 @@ impl ScriptContext {
///
/// This function fails if there is no root frame.
fn reflow(&mut self, goal: ReflowGoal) {
debug!("script: performing reflow");
debug!("script: performing reflow for goal %?", goal);

// Now, join the layout so that they will see the latest changes we have made.
self.join_layout();

5 comments on commit 72f5e5f

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo replied Jun 28, 2013

saw approval from metajack
at sethfowler@72f5e5f

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo replied Jun 28, 2013

merging sfowler/servo/run-layout-once = 72f5e5f into auto

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo replied Jun 28, 2013

sfowler/servo/run-layout-once = 72f5e5f merged ok, testing candidate = fed4f95

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo replied Jun 28, 2013

fast-forwarding master to auto = fed4f95

Please sign in to comment.
You can’t perform that action at this time.