Skip to content
Permalink
Browse files

HACK: don't call media_source_failure_steps when eos

Because gstreamer's appsrc queue might be big enough to swallow
the whole video holding the metadata extraction until EOS.
  • Loading branch information...
ceyusa authored and ferjm committed Aug 21, 2018
1 parent ce76b57 commit 77c7eda0bfe659fde191d0bb48cf6b124a5f4fd6
Showing with 2 additions and 2 deletions.
  1. +2 −2 components/script/dom/htmlmediaelement.rs
@@ -1138,8 +1138,8 @@ impl FetchResponseListener for HTMLMediaElementContext {
// format, or can otherwise not be rendered at all"
if !elem.have_metadata.get() {
// FIXME(victor): adjust player's max-size (or buffering)
elem.queue_dedicated_media_source_failure_steps();
// => "Once the entire media resource has been fetched..."
//elem.queue_dedicated_media_source_failure_steps();
// => "Once the entire media resource has been fetched..."
} else if status.is_ok() {
elem.change_ready_state(ReadyState::HaveEnoughData);

0 comments on commit 77c7eda

Please sign in to comment.
You can’t perform that action at this time.