Permalink
Browse files

Auto merge of #22850 - georgeroman:implement_htmlareaelement_target_a…

…ttribute, r=ferjm

Implement the target attribute for HTMLAreaElement

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #22515

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22850)
<!-- Reviewable:end -->
  • Loading branch information...
bors-servo committed Feb 11, 2019
2 parents aeeaf9d + 90b5d0d commit 7ed6b9d3ce81ff562344cd9f683be224080de9c7
@@ -299,6 +299,12 @@ impl VirtualMethods for HTMLAreaElement {
}

impl HTMLAreaElementMethods for HTMLAreaElement {
// https://html.spec.whatwg.org/multipage/#attr-hyperlink-target
make_getter!(Target, "target");

// https://html.spec.whatwg.org/multipage/#attr-hyperlink-target
make_setter!(SetTarget, "target");

// https://html.spec.whatwg.org/multipage/#dom-area-rellist
fn RelList(&self) -> DomRoot<DOMTokenList> {
self.rel_list
@@ -11,8 +11,8 @@ interface HTMLAreaElement : HTMLElement {
// attribute DOMString coords;
// [CEReactions]
// attribute DOMString shape;
// [CEReactions]
// attribute DOMString target;
[CEReactions]
attribute DOMString target;
// [CEReactions]
// attribute DOMString download;
// [CEReactions]
@@ -1898,9 +1898,6 @@
[HTMLAreaElement interface: attribute shape]
expected: FAIL

[HTMLAreaElement interface: attribute target]
expected: FAIL

[HTMLAreaElement interface: attribute download]
expected: FAIL

@@ -1964,9 +1961,6 @@
[HTMLAreaElement interface: document.createElement("area") must inherit property "shape" with the proper type]
expected: FAIL

[HTMLAreaElement interface: document.createElement("area") must inherit property "target" with the proper type]
expected: FAIL

[HTMLAreaElement interface: document.createElement("area") must inherit property "download" with the proper type]
expected: FAIL

@@ -6912,9 +6906,6 @@
[HTMLAreaElement interface: attribute shape]
expected: FAIL

[HTMLAreaElement interface: attribute target]
expected: FAIL

[HTMLAreaElement interface: attribute download]
expected: FAIL

@@ -6978,9 +6969,6 @@
[HTMLAreaElement interface: document.createElement("area") must inherit property "shape" with the proper type]
expected: FAIL

[HTMLAreaElement interface: document.createElement("area") must inherit property "target" with the proper type]
expected: FAIL

[HTMLAreaElement interface: document.createElement("area") must inherit property "download" with the proper type]
expected: FAIL

0 comments on commit 7ed6b9d

Please sign in to comment.