Implement nodeName on Attr

servo · Apr 3, 2016 · 8cbcdfb · 8cbcdfb
1 parent 7f4929d
commit 8cbcdfb
Show file tree

Hide file tree

Showing 7 changed files with 10 additions and 80 deletions.
diff --git a/components/script/dom/attr.rs b/components/script/dom/attr.rs
@@ -138,6 +138,11 @@ impl AttrMethods for Attr {
         DOMString::from(&*self.identifier.name)
     }
 
+    // https://dom.spec.whatwg.org/#dom-attr-nodename
+    fn NodeName(&self) -> DOMString {
+        self.Name()
+    }
+
     // https://dom.spec.whatwg.org/#dom-attr-namespaceuri
     fn GetNamespaceURI(&self) -> Option<DOMString> {
         let Namespace(ref atom) = self.identifier.namespace;

diff --git a/components/script/dom/webidls/Attr.webidl b/components/script/dom/webidls/Attr.webidl
@@ -17,12 +17,14 @@ interface Attr {
   readonly attribute DOMString localName;
   [Constant]
   readonly attribute DOMString name;
+  [Constant]
+  readonly attribute DOMString nodeName; // historical alias of .name
   [Pure]
            attribute DOMString value;
   [Pure]
-           attribute DOMString textContent; // alias of .value
+           attribute DOMString textContent; // historical alias of .value
   [Pure]
-           attribute DOMString nodeValue; // alias of .value
+           attribute DOMString nodeValue; // historical alias of .value
 
   [Pure]
   readonly attribute Element? ownerElement;

diff --git a/tests/wpt/metadata/dom/nodes/Document-createAttribute.html.ini b/tests/wpt/metadata/dom/nodes/Document-createAttribute.html.ini
diff --git a/tests/wpt/metadata/dom/nodes/Element-removeAttributeNS.html.ini b/tests/wpt/metadata/dom/nodes/Element-removeAttributeNS.html.ini
diff --git a/tests/wpt/metadata/dom/nodes/attributes.html.ini b/tests/wpt/metadata/dom/nodes/attributes.html.ini
diff --git a/tests/wpt/metadata/html/dom/elements/global-attributes/custom-attrs.html.ini b/tests/wpt/metadata/html/dom/elements/global-attributes/custom-attrs.html.ini
diff --git a/tests/wpt/metadata/html/dom/interfaces.html.ini b/tests/wpt/metadata/html/dom/interfaces.html.ini
@@ -8036,7 +8036,7 @@
 
   [Document interface: iframe.contentDocument must inherit property "createTreeWalker" with the proper type (27)]
     expected: FAIL
-  
+
   [Document interface: iframe.contentDocument must inherit property "styleSheets" with the proper type (28)]
     expected: FAIL