From 8dcd2f331d1284ea0255c8f1b0e70f8cdbf53cbd Mon Sep 17 00:00:00 2001 From: Ms2ger Date: Mon, 5 Sep 2016 18:02:14 +0200 Subject: [PATCH] Implement error reporting for workers. Fixes #3311. Fixes #13158. --- components/script/dom/bindings/global.rs | 2 +- .../script/dom/dedicatedworkerglobalscope.rs | 46 +++++++++++++++++- .../dom/webidls/WorkerGlobalScope.webidl | 2 +- components/script/dom/worker.rs | 47 ++++++++++++++++++- components/script/dom/workerglobalscope.rs | 13 ++++- ...WorkerGlobalScope_ErrorEvent_colno.htm.ini | 6 --- ...kerGlobalScope_ErrorEvent_filename.htm.ini | 6 --- ...orkerGlobalScope_ErrorEvent_lineno.htm.ini | 6 --- ...rkerGlobalScope_ErrorEvent_message.htm.ini | 6 --- ...rker_ErrorEvent_bubbles_cancelable.htm.ini | 6 --- .../Worker_ErrorEvent_filename.htm.ini | 6 --- .../workers/Worker_ErrorEvent_lineno.htm.ini | 6 --- .../workers/Worker_ErrorEvent_message.htm.ini | 6 --- .../workers/Worker_ErrorEvent_type.htm.ini | 6 --- .../baseurl/alpha/sharedworker.html.ini | 3 +- .../Worker/AbstractWorker.onerror.html.ini | 6 --- .../metadata/workers/interfaces.worker.js.ini | 3 -- .../onerror/exception-in-onerror.html.ini | 6 --- .../onerror/handled.html.ini | 6 --- .../onerror/not-handled.html.ini | 6 --- .../propagate-to-window-onerror.html.ini | 6 --- .../semantics/run-a-worker/003.html.ini | 4 -- 22 files changed, 104 insertions(+), 100 deletions(-) delete mode 100644 tests/wpt/metadata/workers/WorkerGlobalScope_ErrorEvent_colno.htm.ini delete mode 100644 tests/wpt/metadata/workers/WorkerGlobalScope_ErrorEvent_filename.htm.ini delete mode 100644 tests/wpt/metadata/workers/WorkerGlobalScope_ErrorEvent_lineno.htm.ini delete mode 100644 tests/wpt/metadata/workers/WorkerGlobalScope_ErrorEvent_message.htm.ini delete mode 100644 tests/wpt/metadata/workers/Worker_ErrorEvent_bubbles_cancelable.htm.ini delete mode 100644 tests/wpt/metadata/workers/Worker_ErrorEvent_filename.htm.ini delete mode 100644 tests/wpt/metadata/workers/Worker_ErrorEvent_lineno.htm.ini delete mode 100644 tests/wpt/metadata/workers/Worker_ErrorEvent_message.htm.ini delete mode 100644 tests/wpt/metadata/workers/Worker_ErrorEvent_type.htm.ini delete mode 100644 tests/wpt/metadata/workers/constructors/Worker/AbstractWorker.onerror.html.ini delete mode 100644 tests/wpt/metadata/workers/interfaces/WorkerGlobalScope/onerror/exception-in-onerror.html.ini delete mode 100644 tests/wpt/metadata/workers/interfaces/WorkerGlobalScope/onerror/handled.html.ini delete mode 100644 tests/wpt/metadata/workers/interfaces/WorkerGlobalScope/onerror/not-handled.html.ini delete mode 100644 tests/wpt/metadata/workers/interfaces/WorkerGlobalScope/onerror/propagate-to-window-onerror.html.ini diff --git a/components/script/dom/bindings/global.rs b/components/script/dom/bindings/global.rs index af4cd59a86f6..3fe56e747c2f 100644 --- a/components/script/dom/bindings/global.rs +++ b/components/script/dom/bindings/global.rs @@ -292,7 +292,7 @@ impl<'a> GlobalRef<'a> { pub fn report_an_error(&self, error_info: ErrorInfo, value: HandleValue) { match *self { GlobalRef::Window(ref window) => window.report_an_error(error_info, value), - GlobalRef::Worker(_) => (), + GlobalRef::Worker(ref worker) => worker.report_an_error(error_info, value), } } } diff --git a/components/script/dom/dedicatedworkerglobalscope.rs b/components/script/dom/dedicatedworkerglobalscope.rs index d537d8f3fd3c..89427a602efe 100644 --- a/components/script/dom/dedicatedworkerglobalscope.rs +++ b/components/script/dom/dedicatedworkerglobalscope.rs @@ -10,15 +10,18 @@ use dom::bindings::cell::DOMRefCell; use dom::bindings::codegen::Bindings::DedicatedWorkerGlobalScopeBinding; use dom::bindings::codegen::Bindings::DedicatedWorkerGlobalScopeBinding::DedicatedWorkerGlobalScopeMethods; use dom::bindings::codegen::Bindings::EventHandlerBinding::EventHandlerNonNull; -use dom::bindings::error::ErrorResult; +use dom::bindings::error::{ErrorInfo, ErrorResult}; use dom::bindings::global::{GlobalRef, global_root_from_context}; use dom::bindings::inheritance::Castable; use dom::bindings::js::{Root, RootCollection}; use dom::bindings::reflector::Reflectable; use dom::bindings::str::DOMString; use dom::bindings::structuredclone::StructuredCloneData; +use dom::errorevent::ErrorEvent; +use dom::event::{Event, EventBubbles, EventCancelable}; +use dom::eventtarget::EventTarget; use dom::messageevent::MessageEvent; -use dom::worker::{TrustedWorkerAddress, WorkerMessageHandler}; +use dom::worker::{TrustedWorkerAddress, WorkerErrorHandler, WorkerMessageHandler}; use dom::workerglobalscope::WorkerGlobalScope; use ipc_channel::ipc::{self, IpcReceiver, IpcSender}; use ipc_channel::router::ROUTER; @@ -32,6 +35,7 @@ use rand::random; use script_runtime::ScriptThreadEventCategory::WorkerEvent; use script_runtime::{CommonScriptMsg, ScriptChan, ScriptPort, StackRootTLS, get_reports, new_rt_and_cx}; use script_traits::{TimerEvent, TimerSource, WorkerScriptLoadOrigin, WorkerGlobalScopeInit}; +use std::cell::Cell; use std::mem::replace; use std::sync::atomic::AtomicBool; use std::sync::mpsc::{Receiver, RecvError, Select, Sender, channel}; @@ -88,6 +92,8 @@ pub struct DedicatedWorkerGlobalScope { #[ignore_heap_size_of = "Can't measure trait objects"] /// Sender to the parent thread. parent_sender: Box, + /// https://html.spec.whatwg.org/multipage/#in-error-reporting-mode + in_error_reporting_mode: Cell } impl DedicatedWorkerGlobalScope { @@ -116,6 +122,7 @@ impl DedicatedWorkerGlobalScope { timer_event_port: timer_event_port, parent_sender: parent_sender, worker: DOMRefCell::new(None), + in_error_reporting_mode: Cell::new(false), } } @@ -339,6 +346,41 @@ impl DedicatedWorkerGlobalScope { } } } + + /// https://html.spec.whatwg.org/multipage/#report-the-error + pub fn report_an_error(&self, error_info: ErrorInfo, value: HandleValue) { + // Step 1. + if self.in_error_reporting_mode.get() { + return; + } + + // Step 2. + self.in_error_reporting_mode.set(true); + + // Steps 3-12. + let event = ErrorEvent::new(GlobalRef::Worker(self.upcast()), + atom!("error"), + EventBubbles::DoesNotBubble, + EventCancelable::Cancelable, + error_info.message.as_str().into(), + error_info.filename.as_str().into(), + error_info.lineno, + error_info.column, + value); + + // Step 13. + let handled = !event.upcast::().fire(self.upcast::()); + if !handled { + let worker = self.worker.borrow().as_ref().unwrap().clone(); + // TODO: Should use the DOM manipulation task source. + self.parent_sender + .send(CommonScriptMsg::RunnableMsg(WorkerEvent, + box WorkerErrorHandler::new(worker, error_info))) + .unwrap(); + } + + self.in_error_reporting_mode.set(false); + } } #[allow(unsafe_code)] diff --git a/components/script/dom/webidls/WorkerGlobalScope.webidl b/components/script/dom/webidls/WorkerGlobalScope.webidl index ec65bcb09a65..cc9fb292cd3f 100644 --- a/components/script/dom/webidls/WorkerGlobalScope.webidl +++ b/components/script/dom/webidls/WorkerGlobalScope.webidl @@ -9,7 +9,7 @@ interface WorkerGlobalScope : EventTarget { readonly attribute WorkerLocation location; //void close(); - // attribute OnErrorEventHandler onerror; + attribute OnErrorEventHandler onerror; // attribute EventHandler onlanguagechange; // attribute EventHandler onoffline; // attribute EventHandler ononline; diff --git a/components/script/dom/worker.rs b/components/script/dom/worker.rs index f171d1ee5154..b21c2c7d921c 100644 --- a/components/script/dom/worker.rs +++ b/components/script/dom/worker.rs @@ -8,7 +8,7 @@ use dom::abstractworker::{SimpleWorkerErrorHandler, SharedRt}; use dom::bindings::codegen::Bindings::EventHandlerBinding::EventHandlerNonNull; use dom::bindings::codegen::Bindings::WorkerBinding; use dom::bindings::codegen::Bindings::WorkerBinding::WorkerMethods; -use dom::bindings::error::{Error, ErrorResult, Fallible}; +use dom::bindings::error::{Error, ErrorResult, Fallible, ErrorInfo}; use dom::bindings::global::GlobalRef; use dom::bindings::inheritance::Castable; use dom::bindings::js::Root; @@ -17,11 +17,13 @@ use dom::bindings::reflector::{Reflectable, reflect_dom_object}; use dom::bindings::str::DOMString; use dom::bindings::structuredclone::StructuredCloneData; use dom::dedicatedworkerglobalscope::DedicatedWorkerGlobalScope; +use dom::errorevent::ErrorEvent; +use dom::event::{Event, EventBubbles, EventCancelable}; use dom::eventtarget::EventTarget; use dom::messageevent::MessageEvent; use dom::workerglobalscope::prepare_workerscope_init; use ipc_channel::ipc; -use js::jsapi::{HandleValue, JSContext, JSAutoCompartment}; +use js::jsapi::{HandleValue, JSContext, JSAutoCompartment, NullHandleValue}; use js::jsval::UndefinedValue; use script_thread::Runnable; use script_traits::WorkerScriptLoadOrigin; @@ -137,6 +139,26 @@ impl Worker { let worker = address.root(); worker.upcast().fire_simple_event("error"); } + + fn dispatch_error(&self, error_info: ErrorInfo) { + let global = self.global(); + let event = ErrorEvent::new(global.r(), + atom!("error"), + EventBubbles::DoesNotBubble, + EventCancelable::Cancelable, + error_info.message.as_str().into(), + error_info.filename.as_str().into(), + error_info.lineno, + error_info.column, + NullHandleValue); + + let handled = !event.upcast::().fire(self.upcast::()); + if handled { + return; + } + + global.r().report_an_error(error_info, NullHandleValue); + } } impl WorkerMethods for Worker { @@ -202,3 +224,24 @@ impl Runnable for SimpleWorkerErrorHandler { Worker::dispatch_simple_error(this.addr); } } + +pub struct WorkerErrorHandler { + address: Trusted, + error_info: ErrorInfo, +} + +impl WorkerErrorHandler { + pub fn new(address: Trusted, error_info: ErrorInfo) -> WorkerErrorHandler { + WorkerErrorHandler { + address: address, + error_info: error_info, + } + } +} + +impl Runnable for WorkerErrorHandler { + fn handler(self: Box) { + let this = *self; + this.address.root().dispatch_error(this.error_info); + } +} diff --git a/components/script/dom/workerglobalscope.rs b/components/script/dom/workerglobalscope.rs index 9f61753ca644..01e3ddb47299 100644 --- a/components/script/dom/workerglobalscope.rs +++ b/components/script/dom/workerglobalscope.rs @@ -3,9 +3,10 @@ * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ use devtools_traits::{DevtoolScriptControlMsg, ScriptToDevtoolsControlMsg, WorkerId}; +use dom::bindings::codegen::Bindings::EventHandlerBinding::OnErrorEventHandlerNonNull; use dom::bindings::codegen::Bindings::FunctionBinding::Function; use dom::bindings::codegen::Bindings::WorkerGlobalScopeBinding::WorkerGlobalScopeMethods; -use dom::bindings::error::{Error, ErrorResult, Fallible, report_pending_exception}; +use dom::bindings::error::{Error, ErrorResult, Fallible, report_pending_exception, ErrorInfo}; use dom::bindings::global::GlobalRef; use dom::bindings::inheritance::Castable; use dom::bindings::js::{JS, MutNullableHeap, Root}; @@ -248,6 +249,9 @@ impl WorkerGlobalScopeMethods for WorkerGlobalScope { }) } + // https://html.spec.whatwg.org/multipage/#handler-workerglobalscope-onerror + error_event_handler!(error, GetOnerror, SetOnerror); + // https://html.spec.whatwg.org/multipage/#dom-workerglobalscope-importscripts fn ImportScripts(&self, url_strings: Vec) -> ErrorResult { let mut urls = Vec::with_capacity(url_strings.len()); @@ -451,4 +455,11 @@ impl WorkerGlobalScope { closing.store(true, Ordering::SeqCst); } } + + /// https://html.spec.whatwg.org/multipage/#report-the-error + pub fn report_an_error(&self, error_info: ErrorInfo, value: HandleValue) { + self.downcast::() + .expect("Should implement report_an_error for this worker") + .report_an_error(error_info, value); + } } diff --git a/tests/wpt/metadata/workers/WorkerGlobalScope_ErrorEvent_colno.htm.ini b/tests/wpt/metadata/workers/WorkerGlobalScope_ErrorEvent_colno.htm.ini deleted file mode 100644 index 158e473da7a4..000000000000 --- a/tests/wpt/metadata/workers/WorkerGlobalScope_ErrorEvent_colno.htm.ini +++ /dev/null @@ -1,6 +0,0 @@ -[WorkerGlobalScope_ErrorEvent_colno.htm] - type: testharness - expected: TIMEOUT - [ WorkerGlobalScope onerror event handler argument: col ] - expected: TIMEOUT - diff --git a/tests/wpt/metadata/workers/WorkerGlobalScope_ErrorEvent_filename.htm.ini b/tests/wpt/metadata/workers/WorkerGlobalScope_ErrorEvent_filename.htm.ini deleted file mode 100644 index 8f4d379cfc51..000000000000 --- a/tests/wpt/metadata/workers/WorkerGlobalScope_ErrorEvent_filename.htm.ini +++ /dev/null @@ -1,6 +0,0 @@ -[WorkerGlobalScope_ErrorEvent_filename.htm] - type: testharness - expected: TIMEOUT - [ WorkerGlobalScope onerror event handler argument: location ] - expected: TIMEOUT - diff --git a/tests/wpt/metadata/workers/WorkerGlobalScope_ErrorEvent_lineno.htm.ini b/tests/wpt/metadata/workers/WorkerGlobalScope_ErrorEvent_lineno.htm.ini deleted file mode 100644 index 73f26d8f9b9a..000000000000 --- a/tests/wpt/metadata/workers/WorkerGlobalScope_ErrorEvent_lineno.htm.ini +++ /dev/null @@ -1,6 +0,0 @@ -[WorkerGlobalScope_ErrorEvent_lineno.htm] - type: testharness - expected: TIMEOUT - [ WorkerGlobalScope onerror event handler argument: line ] - expected: TIMEOUT - diff --git a/tests/wpt/metadata/workers/WorkerGlobalScope_ErrorEvent_message.htm.ini b/tests/wpt/metadata/workers/WorkerGlobalScope_ErrorEvent_message.htm.ini deleted file mode 100644 index 7e13c7b35b03..000000000000 --- a/tests/wpt/metadata/workers/WorkerGlobalScope_ErrorEvent_message.htm.ini +++ /dev/null @@ -1,6 +0,0 @@ -[WorkerGlobalScope_ErrorEvent_message.htm] - type: testharness - expected: TIMEOUT - [ WorkerGlobalScope onerror event handler argument: message ] - expected: TIMEOUT - diff --git a/tests/wpt/metadata/workers/Worker_ErrorEvent_bubbles_cancelable.htm.ini b/tests/wpt/metadata/workers/Worker_ErrorEvent_bubbles_cancelable.htm.ini deleted file mode 100644 index b5171d68e025..000000000000 --- a/tests/wpt/metadata/workers/Worker_ErrorEvent_bubbles_cancelable.htm.ini +++ /dev/null @@ -1,6 +0,0 @@ -[Worker_ErrorEvent_bubbles_cancelable.htm] - type: testharness - expected: TIMEOUT - [ErrorEvent on worker doesn't bubble and is cancelable] - expected: TIMEOUT - diff --git a/tests/wpt/metadata/workers/Worker_ErrorEvent_filename.htm.ini b/tests/wpt/metadata/workers/Worker_ErrorEvent_filename.htm.ini deleted file mode 100644 index 22fd38a73285..000000000000 --- a/tests/wpt/metadata/workers/Worker_ErrorEvent_filename.htm.ini +++ /dev/null @@ -1,6 +0,0 @@ -[Worker_ErrorEvent_filename.htm] - type: testharness - expected: TIMEOUT - [ AbstractWorker ErrorEvent.filename ] - expected: TIMEOUT - diff --git a/tests/wpt/metadata/workers/Worker_ErrorEvent_lineno.htm.ini b/tests/wpt/metadata/workers/Worker_ErrorEvent_lineno.htm.ini deleted file mode 100644 index 91f945e647c8..000000000000 --- a/tests/wpt/metadata/workers/Worker_ErrorEvent_lineno.htm.ini +++ /dev/null @@ -1,6 +0,0 @@ -[Worker_ErrorEvent_lineno.htm] - type: testharness - expected: TIMEOUT - [ AbstractWorker ErrorEvent.lineno ] - expected: TIMEOUT - diff --git a/tests/wpt/metadata/workers/Worker_ErrorEvent_message.htm.ini b/tests/wpt/metadata/workers/Worker_ErrorEvent_message.htm.ini deleted file mode 100644 index 51293d0268c1..000000000000 --- a/tests/wpt/metadata/workers/Worker_ErrorEvent_message.htm.ini +++ /dev/null @@ -1,6 +0,0 @@ -[Worker_ErrorEvent_message.htm] - type: testharness - expected: TIMEOUT - [ AbstractWorker ErrorEvent.message ] - expected: TIMEOUT - diff --git a/tests/wpt/metadata/workers/Worker_ErrorEvent_type.htm.ini b/tests/wpt/metadata/workers/Worker_ErrorEvent_type.htm.ini deleted file mode 100644 index bd8fa1158357..000000000000 --- a/tests/wpt/metadata/workers/Worker_ErrorEvent_type.htm.ini +++ /dev/null @@ -1,6 +0,0 @@ -[Worker_ErrorEvent_type.htm] - type: testharness - expected: TIMEOUT - [ AbstractWorker ErrorEvent.type ] - expected: TIMEOUT - diff --git a/tests/wpt/metadata/workers/baseurl/alpha/sharedworker.html.ini b/tests/wpt/metadata/workers/baseurl/alpha/sharedworker.html.ini index e4c8d44755fe..de9df5b161eb 100644 --- a/tests/wpt/metadata/workers/baseurl/alpha/sharedworker.html.ini +++ b/tests/wpt/metadata/workers/baseurl/alpha/sharedworker.html.ini @@ -1,6 +1,5 @@ [sharedworker.html] type: testharness - expected: TIMEOUT [Base URL in workers: new SharedWorker()] - expected: TIMEOUT + expected: FAIL diff --git a/tests/wpt/metadata/workers/constructors/Worker/AbstractWorker.onerror.html.ini b/tests/wpt/metadata/workers/constructors/Worker/AbstractWorker.onerror.html.ini deleted file mode 100644 index d847fee77774..000000000000 --- a/tests/wpt/metadata/workers/constructors/Worker/AbstractWorker.onerror.html.ini +++ /dev/null @@ -1,6 +0,0 @@ -[AbstractWorker.onerror.html] - type: testharness - expected: TIMEOUT - [AbstractWorker.onerror] - expected: TIMEOUT - diff --git a/tests/wpt/metadata/workers/interfaces.worker.js.ini b/tests/wpt/metadata/workers/interfaces.worker.js.ini index eddc260926b4..9111901ba732 100644 --- a/tests/wpt/metadata/workers/interfaces.worker.js.ini +++ b/tests/wpt/metadata/workers/interfaces.worker.js.ini @@ -21,9 +21,6 @@ [DedicatedWorkerGlobalScope interface: attribute onmessage] expected: FAIL - [WorkerGlobalScope interface: self must inherit property "onerror" with the proper type (3)] - expected: FAIL - [WorkerGlobalScope interface: self must inherit property "onlanguagechange" with the proper type (4)] expected: FAIL diff --git a/tests/wpt/metadata/workers/interfaces/WorkerGlobalScope/onerror/exception-in-onerror.html.ini b/tests/wpt/metadata/workers/interfaces/WorkerGlobalScope/onerror/exception-in-onerror.html.ini deleted file mode 100644 index 17f23fe3030a..000000000000 --- a/tests/wpt/metadata/workers/interfaces/WorkerGlobalScope/onerror/exception-in-onerror.html.ini +++ /dev/null @@ -1,6 +0,0 @@ -[exception-in-onerror.html] - type: testharness - expected: TIMEOUT - [onerror, "not handled" with an error in the onerror function] - expected: TIMEOUT - diff --git a/tests/wpt/metadata/workers/interfaces/WorkerGlobalScope/onerror/handled.html.ini b/tests/wpt/metadata/workers/interfaces/WorkerGlobalScope/onerror/handled.html.ini deleted file mode 100644 index 2a533abd72ac..000000000000 --- a/tests/wpt/metadata/workers/interfaces/WorkerGlobalScope/onerror/handled.html.ini +++ /dev/null @@ -1,6 +0,0 @@ -[handled.html] - type: testharness - expected: TIMEOUT - [onerror, "handled"] - expected: TIMEOUT - diff --git a/tests/wpt/metadata/workers/interfaces/WorkerGlobalScope/onerror/not-handled.html.ini b/tests/wpt/metadata/workers/interfaces/WorkerGlobalScope/onerror/not-handled.html.ini deleted file mode 100644 index e2c53cad4841..000000000000 --- a/tests/wpt/metadata/workers/interfaces/WorkerGlobalScope/onerror/not-handled.html.ini +++ /dev/null @@ -1,6 +0,0 @@ -[not-handled.html] - type: testharness - expected: TIMEOUT - [onerror, "not handled"] - expected: TIMEOUT - diff --git a/tests/wpt/metadata/workers/interfaces/WorkerGlobalScope/onerror/propagate-to-window-onerror.html.ini b/tests/wpt/metadata/workers/interfaces/WorkerGlobalScope/onerror/propagate-to-window-onerror.html.ini deleted file mode 100644 index 508a59a7c224..000000000000 --- a/tests/wpt/metadata/workers/interfaces/WorkerGlobalScope/onerror/propagate-to-window-onerror.html.ini +++ /dev/null @@ -1,6 +0,0 @@ -[propagate-to-window-onerror.html] - type: testharness - expected: TIMEOUT - [onerror, "not handled" with only window.onerror defined] - expected: TIMEOUT - diff --git a/tests/wpt/metadata/workers/semantics/run-a-worker/003.html.ini b/tests/wpt/metadata/workers/semantics/run-a-worker/003.html.ini index 132189cae6e5..d6e39444229f 100644 --- a/tests/wpt/metadata/workers/semantics/run-a-worker/003.html.ini +++ b/tests/wpt/metadata/workers/semantics/run-a-worker/003.html.ini @@ -1,9 +1,5 @@ [003.html] type: testharness - expected: TIMEOUT - [worker] - expected: TIMEOUT - [shared] expected: FAIL