Permalink
Browse files

Auto merge of #22676 - ferjm:textrack.activecues, r=jdm

Expose TextTrack.activeCues

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #22675

This only exposes the `activeCues` property to make sure that `/html/semantics/embedded-content/media-elements/track/track-element/track-active-cues.html` timeouts consistently.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22676)
<!-- Reviewable:end -->
  • Loading branch information...
bors-servo committed Jan 11, 2019
2 parents b49e751 + 69a79c7 commit 90c0d27ce7695323d43618fa9fb22d887fe154ee
@@ -110,6 +110,13 @@ impl TextTrackMethods for TextTrack {
}
}

// https://html.spec.whatwg.org/multipage/#dom-texttrack-activecues
fn GetActiveCues(&self) -> Option<DomRoot<TextTrackCueList>> {
// XXX implement active cues logic
// https://github.com/servo/servo/issues/22314
None
}

// https://html.spec.whatwg.org/multipage/#dom-texttrack-addcue
fn AddCue(&self, cue: &TextTrackCue) -> ErrorResult {
// FIXME(#22314, dlrobertson) add Step 1 & 2
@@ -19,7 +19,7 @@ interface TextTrack : EventTarget {
attribute TextTrackMode mode;

readonly attribute TextTrackCueList? cues;
// readonly attribute TextTrackCueList? activeCues;
readonly attribute TextTrackCueList? activeCues;

[Throws]
void addCue(TextTrackCue cue);
@@ -9563,15 +9563,9 @@
[TextTrack interface: attribute inBandMetadataTrackDispatchType]
expected: FAIL

[TextTrack interface: attribute activeCues]
expected: FAIL

[TextTrack interface: document.createElement("track").track must inherit property "inBandMetadataTrackDispatchType" with the proper type]
expected: FAIL

[TextTrack interface: document.createElement("track").track must inherit property "activeCues" with the proper type]
expected: FAIL

[TimeRanges must be primary interface of document.createElement("video").buffered]
expected: FAIL

0 comments on commit 90c0d27

Please sign in to comment.