diff --git a/components/layout/construct.rs b/components/layout/construct.rs index 2a75c4025cb4..77b388e8ade4 100644 --- a/components/layout/construct.rs +++ b/components/layout/construct.rs @@ -1501,7 +1501,15 @@ impl<'a, ConcreteThreadSafeLayoutNode> PostorderNodeMutTraversal bool { + fn process(&mut self, node: &ConcreteThreadSafeLayoutNode) { + node.insert_flags(HAS_NEWLY_CONSTRUCTED_FLOW); + + // Bail out if this node has an ancestor with display: none. + if node.style(self.style_context()).get_inheritedbox()._servo_under_display_none.0 { + self.set_flow_construction_result(node, ConstructionResult::None); + return; + } + // Get the `display` property for this node, and determine whether this node is floated. let (display, float, positioning) = match node.type_id() { None => { @@ -1542,12 +1550,8 @@ impl<'a, ConcreteThreadSafeLayoutNode> PostorderNodeMutTraversal { - for child in node.children() { - self.set_flow_construction_result(&child, ConstructionResult::None); - } self.set_flow_construction_result(node, ConstructionResult::None); } @@ -1654,9 +1658,6 @@ impl<'a, ConcreteThreadSafeLayoutNode> PostorderNodeMutTraversal>, new: &ServoCompute ], [ get_box.float, get_box.display, get_box.position, get_counters.content, get_counters.counter_reset, get_counters.counter_increment, + get_inheritedbox._servo_under_display_none, get_list.quotes, get_list.list_style_type, // If these text or font properties change, we need to reconstruct the flow so that diff --git a/components/layout/traversal.rs b/components/layout/traversal.rs index 1fe5388549e7..692d956f0007 100644 --- a/components/layout/traversal.rs +++ b/components/layout/traversal.rs @@ -72,7 +72,7 @@ impl<'lc, 'ln> DomTraversalContext> for RecalcStyleAndConst /// A bottom-up, parallelizable traversal. pub trait PostorderNodeMutTraversal { /// The operation to perform. Return true to continue or false to stop. - fn process(&mut self, node: &ConcreteThreadSafeLayoutNode) -> bool; + fn process(&mut self, node: &ConcreteThreadSafeLayoutNode); } /// The flow construction traversal, which builds flows for styled nodes. diff --git a/components/style/properties/longhand/box.mako.rs b/components/style/properties/longhand/box.mako.rs index f45973063b5a..800cf276a1aa 100644 --- a/components/style/properties/longhand/box.mako.rs +++ b/components/style/properties/longhand/box.mako.rs @@ -80,6 +80,7 @@ _error_reporter: &mut StdBox) { longhands::_servo_display_for_hypothetical_box::derive_from_display(context); longhands::_servo_text_decorations_in_effect::derive_from_display(context); + longhands::_servo_under_display_none::derive_from_display(context); } % endif diff --git a/components/style/properties/longhand/inherited_box.mako.rs b/components/style/properties/longhand/inherited_box.mako.rs index 6dc6f05c2e76..655d9dac6744 100644 --- a/components/style/properties/longhand/inherited_box.mako.rs +++ b/components/style/properties/longhand/inherited_box.mako.rs @@ -88,3 +88,40 @@ ${helpers.single_keyword("color-adjust", "economy exact", products="gecko")} } } + +// Used in the bottom-up flow construction traversal to avoid constructing flows for +// descendants of nodes with `display: none`. +<%helpers:longhand name="-servo-under-display-none" derived_from="display" products="servo"> + use cssparser::ToCss; + use std::fmt; + use values::computed::ComputedValueAsSpecified; + + #[derive(Copy, Clone, Debug, Eq, PartialEq, HeapSizeOf, Serialize, Deserialize)] + pub struct SpecifiedValue(pub bool); + + pub mod computed_value { + pub type T = super::SpecifiedValue; + } + impl ComputedValueAsSpecified for SpecifiedValue {} + + pub fn get_initial_value() -> computed_value::T { + SpecifiedValue(false) + } + + impl ToCss for SpecifiedValue { + fn to_css(&self, _: &mut W) -> fmt::Result where W: fmt::Write { + Ok(()) // Internal property + } + } + + #[inline] + pub fn derive_from_display(context: &mut Cx) { + use properties::style_struct_traits::Box; + use super::display::computed_value::T as Display; + + if context.style().get_box().clone_display() == Display::none { + context.mutate_style().mutate_inheritedbox() + .set__servo_under_display_none(SpecifiedValue(true)); + } + } +