Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
style: Add telemetry for -moz-appearance usage.
  • Loading branch information
heycam authored and emilio committed Jun 18, 2020
1 parent c578a82 commit 9b980e2
Show file tree
Hide file tree
Showing 3 changed files with 32 additions and 1 deletion.
15 changes: 15 additions & 0 deletions components/style/properties/declaration_block.rs
Expand Up @@ -348,6 +348,21 @@ impl PropertyDeclarationBlock {
.find(|(declaration, _)| declaration.id() == property)
}

/// Get a declaration for a given property with the specified importance.
#[inline]
pub fn get_at_importance(
&self,
property: PropertyDeclarationId,
importance: Importance,
) -> Option<&PropertyDeclaration> {
let (declaration, i) = self.get(property)?;
if i == importance {
Some(declaration)
} else {
None
}
}

/// Tries to serialize a given shorthand from the declarations in this
/// block.
pub fn shorthand_to_css(
Expand Down
15 changes: 15 additions & 0 deletions components/style/properties/longhands/box.mako.rs
Expand Up @@ -627,6 +627,21 @@ ${helpers.predefined_type(
gecko_ffi_name="mAppearance",
)}

// A UA-sheet only property that is always set to the same value as
// -moz-appearance. Used to record telemetry for when author sheets
// override the value of -moz-appearance; see
// nsIFrame::RecordAppearanceTelemetry.
${helpers.predefined_type(
"-moz-default-appearance",
"Appearance",
"computed::Appearance::None",
engines="gecko",
animation_value_type="none",
spec="Internal (not web-exposed)",
enabled_in="ua",
gecko_ffi_name="mDefaultAppearance",
)}

${helpers.single_keyword(
"-moz-orient",
"inline block horizontal vertical",
Expand Down
3 changes: 2 additions & 1 deletion components/style/properties/properties.mako.rs
Expand Up @@ -2111,7 +2111,8 @@ impl PropertyId {
pub struct WideKeywordDeclaration {
#[css(skip)]
id: LonghandId,
keyword: CSSWideKeyword,
/// The CSS-wide keyword.
pub keyword: CSSWideKeyword,
}

/// An unparsed declaration that contains `var()` functions.
Expand Down

0 comments on commit 9b980e2

Please sign in to comment.