./mach clean: cwd is unnecessary when --manifest-path is used

servo · Jul 1, 2019 · aa5e559 · aa5e559
1 parent 9110b25
commit aa5e559
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 8 deletions.
diff --git a/python/servo/build_commands.py b/python/servo/build_commands.py
@@ -712,14 +712,11 @@ def clean(self, manifest_path=None, params=[], verbose=False):
             print('Removing virtualenv directory: %s' % virtualenv_path)
             shutil.rmtree(virtualenv_path)
 
-        opts = []
-        if manifest_path:
-            opts += ["--manifest-path", manifest_path]
+        opts = ["--manifest-path", manifest_path or self.ports_glutin_manifest()]
         if verbose:
             opts += ["-v"]
         opts += params
-        return check_call(["cargo", "clean"] + opts,
-                          env=self.build_env(), cwd=self.ports_glutin_crate(), verbose=verbose)
+        return check_call(["cargo", "clean"] + opts, env=self.build_env(), verbose=verbose)
 
 
 def package_gstreamer_dlls(servo_exe_dir, target):

diff --git a/python/servo/command_base.py b/python/servo/command_base.py
@@ -731,9 +731,6 @@ def package_dir(package):
 
         return env
 
-    def ports_glutin_crate(self):
-        return path.join(self.context.topdir, "ports", "glutin")
-
     def add_manifest_path(self, args, android=False, libsimpleservo=False):
         if "--manifest-path" not in args:
             if libsimpleservo or android: