Skip to content

Commit

Permalink
Fix JS_ObjectIsDate() call in webidl codegen.
Browse files Browse the repository at this point in the history
We were missing the import, and the prototype of the function has
since changed.  Partial fix for #10675
  • Loading branch information
anholt committed Jan 5, 2017
1 parent d90499a commit af380c2
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion components/script/dom/bindings/codegen/CodegenRust.py
Expand Up @@ -467,7 +467,11 @@ def pickFirstSignature(condition, filterLambda):


# Check for Date objects # Check for Date objects
# XXXbz Do we need to worry about security wrappers around the Date? # XXXbz Do we need to worry about security wrappers around the Date?
pickFirstSignature("%s.get().is_object() && JS_ObjectIsDate(cx, &%s.get().to_object())" % pickFirstSignature("%s.get().is_object() && "
"{ rooted!(in(cx) let obj = %s.get().to_object()); "
"let mut is_date = false; "
"assert!(JS_ObjectIsDate(cx, obj.handle(), &mut is_date)); "
"is_date }" %
(distinguishingArg, distinguishingArg), (distinguishingArg, distinguishingArg),
lambda s: (s[1][distinguishingIndex].type.isDate() or lambda s: (s[1][distinguishingIndex].type.isDate() or
s[1][distinguishingIndex].type.isObject())) s[1][distinguishingIndex].type.isObject()))
Expand Down Expand Up @@ -5468,6 +5472,7 @@ def generate_imports(config, cgthings, descriptors, callbacks=None, dictionaries
'js::jsapi::JS_NewObject', 'js::jsapi::JS_NewObject',
'js::jsapi::JS_NewObjectWithGivenProto', 'js::jsapi::JS_NewObjectWithGivenProto',
'js::jsapi::JS_NewObjectWithoutMetadata', 'js::jsapi::JS_NewObjectWithoutMetadata',
'js::jsapi::JS_ObjectIsDate',
'js::jsapi::JS_SetImmutablePrototype', 'js::jsapi::JS_SetImmutablePrototype',
'js::jsapi::JS_SetProperty', 'js::jsapi::JS_SetProperty',
'js::jsapi::JS_SetReservedSlot', 'js::jsapi::JS_SetReservedSlot',
Expand Down

0 comments on commit af380c2

Please sign in to comment.