Skip to content

Commit

Permalink
Remove obsolete logic for LRUCache size
Browse files Browse the repository at this point in the history
The LRUCache implementation has been replaced, and no longer requires a backing store larger than its capacity.
  • Loading branch information
mbrubeck committed Oct 1, 2019
1 parent ad1d003 commit d0913ec
Showing 1 changed file with 3 additions and 6 deletions.
9 changes: 3 additions & 6 deletions components/style/sharing/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -90,17 +90,14 @@ use uluru::{Entry, LRUCache};
mod checks;

/// The amount of nodes that the style sharing candidate cache should hold at
/// most. We'd somewhat like 32, but ArrayDeque only implements certain backing
/// store sizes. A cache size of 32 would mean a backing store of 33, but
/// that's not an implemented size: we can do 32 or 40.
/// most.
///
/// The cache size was chosen by measuring style sharing and resulting
/// performance on a few pages; sizes up to about 32 were giving good sharing
/// improvements (e.g. 3x fewer styles having to be resolved than at size 8) and
/// slight performance improvements. Sizes larger than 32 haven't really been
/// tested.
pub const SHARING_CACHE_SIZE: usize = 31;
const SHARING_CACHE_BACKING_STORE_SIZE: usize = SHARING_CACHE_SIZE + 1;
pub const SHARING_CACHE_SIZE: usize = 32;

/// Opaque pointer type to compare ComputedValues identities.
#[derive(Clone, Debug, Eq, PartialEq)]
Expand Down Expand Up @@ -426,7 +423,7 @@ impl<E: TElement> StyleSharingTarget<E> {
}

struct SharingCacheBase<Candidate> {
entries: LRUCache<[Entry<Candidate>; SHARING_CACHE_BACKING_STORE_SIZE]>,
entries: LRUCache<[Entry<Candidate>; SHARING_CACHE_SIZE]>,
}

impl<Candidate> Default for SharingCacheBase<Candidate> {
Expand Down

0 comments on commit d0913ec

Please sign in to comment.