Skip to content
Permalink
Browse files

Add microtask checkpoints on </script> and CE construct

  • Loading branch information
pshaughn committed Jan 13, 2020
1 parent 968b45f commit e4a5d8d4ab2ac2fd4ecf21f8021e59d660cd9c3f
@@ -21,6 +21,7 @@ use crate::dom::bindings::error::{
use crate::dom::bindings::inheritance::Castable;
use crate::dom::bindings::reflector::{reflect_dom_object, DomObject, Reflector};
use crate::dom::bindings::root::{Dom, DomRoot};
use crate::dom::bindings::settings_stack::is_execution_stack_empty;
use crate::dom::bindings::str::DOMString;
use crate::dom::document::Document;
use crate::dom::domexception::{DOMErrorName, DOMException};
@@ -543,6 +544,14 @@ impl CustomElementDefinition {
}
}

// https://heycam.github.io/webidl/#construct-a-callback-function
// https://html.spec.whatwg.org/multipage/#clean-up-after-running-script
if is_execution_stack_empty() {
window
.upcast::<GlobalScope>()
.perform_a_microtask_checkpoint();
}

rooted!(in(*cx) let element_val = ObjectValue(element.get()));
let element: DomRoot<Element> =
match unsafe { DomRoot::from_jsval(*cx, element_val.handle(), ()) } {
@@ -690,6 +699,15 @@ fn run_upgrade_constructor(
} {
return Err(Error::JSFailed);
}

// https://heycam.github.io/webidl/#construct-a-callback-function
// https://html.spec.whatwg.org/multipage/#clean-up-after-running-script
if is_execution_stack_empty() {
window
.upcast::<GlobalScope>()
.perform_a_microtask_checkpoint();
}

// Step 8.3
let mut same = false;
rooted!(in(*cx) let construct_result_val = ObjectValue(construct_result.get()));
@@ -558,6 +558,19 @@ impl ServoParser {
Err(script) => script,
};

// https://html.spec.whatwg.org/multipage/#parsing-main-incdata
// branch "An end tag whose tag name is "script"
// The spec says to perform the microtask checkpoint before
// setting the insertion mode to Text, but this is not
// possible with the way servo and html5ever currently
// relate to each other, and hopefully it is not observable.
if is_execution_stack_empty() {
self.document
.window()
.upcast::<GlobalScope>()
.perform_a_microtask_checkpoint();
}

let script_nesting_level = self.script_nesting_level.get();

self.script_nesting_level.set(script_nesting_level + 1);

This file was deleted.

0 comments on commit e4a5d8d

Please sign in to comment.
You can’t perform that action at this time.