From f00bbdb30a3268d6fadb7f0d196f19f6b6bbf3e4 Mon Sep 17 00:00:00 2001 From: Harry Maclean Date: Sun, 3 Aug 2014 23:37:46 +0100 Subject: [PATCH] Check for the empty string before creating a new text node when setting document.title --- src/components/script/dom/document.rs | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/src/components/script/dom/document.rs b/src/components/script/dom/document.rs index 58fef0e527f0..d452560ca464 100644 --- a/src/components/script/dom/document.rs +++ b/src/components/script/dom/document.rs @@ -542,17 +542,19 @@ impl<'a> DocumentMethods for JSRef<'a, Document> { for title_child in title_node.children() { assert!(title_node.RemoveChild(&title_child).is_ok()); } - let new_text = self.CreateTextNode(title.clone()).root(); - - assert!(title_node.AppendChild(NodeCast::from_ref(&*new_text)).is_ok()); + if !title.is_empty() { + let new_text = self.CreateTextNode(title.clone()).root(); + assert!(title_node.AppendChild(NodeCast::from_ref(&*new_text)).is_ok()); + } }, None => { let new_title = HTMLTitleElement::new("title".to_string(), self).root(); let new_title: &JSRef = NodeCast::from_ref(&*new_title); - let new_text = self.CreateTextNode(title.clone()).root(); - - assert!(new_title.AppendChild(NodeCast::from_ref(&*new_text)).is_ok()); + if !title.is_empty() { + let new_text = self.CreateTextNode(title.clone()).root(); + assert!(new_title.AppendChild(NodeCast::from_ref(&*new_text)).is_ok()); + } assert!(head.AppendChild(new_title).is_ok()); }, }