Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix broken viewport percentage length units after a viewport resize.
When a viewport is resized, the computed values for a style containing viewport percentage length units become stale. However, there's no way for those styles to be invalidated after a resize. As a solution, this commit invalidates the computed values cache after a resize has occurred, which is probably over-kill. A better solution would probably be to track under what conditions computed values remain valid, and invalidate them as indicated.
- Loading branch information
Showing
3 changed files
with
19 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fafc357
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from SimonSapin
at luniv@fafc357
fafc357
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging luniv/servo/viewport-length-cached-values-invalidation = fafc357 into auto
fafc357
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
luniv/servo/viewport-length-cached-values-invalidation = fafc357 merged ok, testing candidate = a508070
fafc357
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all tests pass:
success: http://build.servo.org/builders/linux1/builds/1002
success: http://build.servo.org/builders/linux2/builds/1001
success: http://build.servo.org/builders/android/builds/1036
success: http://build.servo.org/builders/mac1/builds/1217
success: http://build.servo.org/builders/mac2/builds/1218
success: http://build.servo.org/builders/gonk/builds/188
fafc357
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fast-forwarding master to auto = a508070