Permalink
Commits on Oct 15, 2018
  1. style: More useful logging for transition-related stuff.

    emilio committed May 6, 2018
    Transitions are still broken, but I found these messages more helpful than the
    previous ones when diagnosing problems.
  2. style: Expire keyframes animations when no longer referenced by the s…

    emilio committed May 5, 2018
    …tyle.
    
    It's a long way to make this sound in general...
    
    Fixes #20731
  3. style: Remove unused expired boolean in Animation::Transition.

    emilio committed May 5, 2018
    The last caller who used was #14418, which did fix a problem but introduced
    multiple. In particular, now transitions don't get expired ever, until they
    finish running of course.
    
    That is not ok, given you can have something that the user can trigger to change
    the style (hi, :hover, for example), and right now that triggers new
    transitions, getting this into a really funny state.
    
    I should give fixing this a shot, but it's non-trivial at all.
  4. style: Remove useless declarations in servo.css.

    emilio committed Oct 14, 2018
    Margin is a reset property, there's no point in setting it to zero since it's
    zero by default.
  5. style: Stop using PseudoElement::inherits_all.

    emilio committed Oct 14, 2018
    This was done that way just because Servo didn't support the `all` property at
    the time.
    
    We should do it this way and optimize it if it's slow. Though I suspect that
    most of stuff doesn't actually need to be inherited, my patch at bug 1498943
    should make it much faster than what it would otherwise be.
Commits on Oct 9, 2018
  1. style: fix tidy issues and update test expectations.

    emilio committed Oct 9, 2018
  2. style: Remove nsCSSValue usage from font code.

    emilio committed Oct 3, 2018
    Really sorry for the size of the patch.
    
    Differential Revision: https://phabricator.services.mozilla.com/D7753
  3. style: Serialize a bunch of image properties with Servo.

    emilio committed Oct 5, 2018
    I had to fix the conversion for BackgroundSize too, hopefully we can
    simplify all this using cbindgen in the future instead of CalcValue.
    
    Differential Revision: https://phabricator.services.mozilla.com/D7580
  4. style: Serialize -moz-image-region and clip with Servo.

    emilio committed Sep 26, 2018
    This changes the serialization of -moz-image-region to be consistent with that
    of clip(), but it's an internal property and the specified value is already
    serialized by Servo so I think it's the right thing to do.
    
    There are also no internal callers of the getter.
    
    Differential Revision: https://phabricator.services.mozilla.com/D7069
  5. style: Don't apply containing shadow-host rules to NAC.

    emilio committed Sep 24, 2018
    This is a regression from bug 1487856.
    
    Differential Revision: https://phabricator.services.mozilla.com/D6700
  6. style: Remove an outdated comment.

    emilio committed Sep 24, 2018
    This was fixed, css/css-scoping/shadow-cascade-order-001.html tests it.
Commits on Sep 22, 2018
  1. Update test expectations.

    emilio committed Sep 22, 2018
  2. Partially revert #21746.

    emilio committed Sep 22, 2018
    This reverts the relevant bits from #21746 so that style and dependencies can
    build with stable.
    
    This is important because:
    
     * `selectors` is a published crate.
    
     * Gecko compiles with stable (more or less).
    
    I reviewed that PR under the assumption that the union feature was stable, since
    untagged unions are stable since 1.19, but turns out that smallvec uses non-Copy
    types in unions, which are still unstable.
    
    This leaves the union feature used on Servo, so that it gets testing, taking
    advantage of features being additive.
  3. style: Back out bug 1481866.

    emilio committed Sep 19, 2018
    The behavior the WG proposed is way more subtle than what that bug implements,
    including:
    
     * Implementing two logical overflow longhands.
     * Expanding the overflow shorthand to different longhands depending on the
       syntax of that.
    
    Meanwhile, Blink hasn't done the swap and will ship the same behavior that we
    shipped in Firefox 61 (bug 1453148), that is, overflow-x, then overflow-y.
    
    So I think lacking a clear way forward we should revert this change and preserve
    our shipped behavior.
    
    Differential Revision: https://phabricator.services.mozilla.com/D6317
Commits on Sep 18, 2018
  1. Fix unit test build.

    emilio committed Sep 18, 2018
  2. Fix Servo build.

    emilio committed Sep 18, 2018
  3. style: Make Servo build.

    emilio committed Sep 18, 2018
    StrongRuleNode is really Sync.
  4. Fix tidy issues.

    emilio committed Sep 18, 2018
  5. style: Make LonghandId::flags an indexing operation.

    emilio committed Sep 18, 2018
    I always see a bunch of time in our profiles in the iterator over the
    declarations, this ensures it's not something dumb.
    
    I suspect it's just a bunch of cache misses from walking the rule tree but in
    any case this is consistent with the other getters we have and such.
    
    Differential Revision: https://phabricator.services.mozilla.com/D5971
  6. style: Remove DeclaredValue.

    emilio committed Sep 17, 2018
    I think it used to be the case that all PropertyDeclaration variants had a
    DeclaredValueOwned<T> inside. But that's no longer the case, so this abstraction
    seems less useful now.
    
    Differential Revision: https://phabricator.services.mozilla.com/D5978
  7. style: Deindent the non-css-wide-keyword-related code from cascade_pr…

    emilio committed Sep 17, 2018
    …operty.
    
    There's no good reason we construct a DeclaredValue as an intermediate step.
    
    Differential Revision: https://phabricator.services.mozilla.com/D5977
  8. style: Remove DeclaredValue::WithVariables.

    emilio committed Sep 17, 2018
    We never construct it.
    
    Differential Revision: https://phabricator.services.mozilla.com/D5976
  9. style: Split apply_declarations into its own file, and without mako.

    emilio committed Sep 17, 2018
    All that font code thrown out in the middle was making me mad.
    
    There should be no change in behavior from this patch.
    
    I ran rustfmt on the code but I corrected manually the following:
    
      rust-lang-nursery/rustfmt#3025
    
    Differential Revision: https://phabricator.services.mozilla.com/D5970
Commits on Sep 15, 2018
  1. style: Fix servo build and drop a FIXME there.

    emilio committed Sep 15, 2018
  2. style: Fix Gecko build.

    emilio committed Sep 15, 2018