Skip to content
Permalink
Branch: master
Commits on Apr 12, 2019
  1. style: Switch to the new scroll-snap-type syntax for the old scroll s…

    hiikezoe authored and emilio committed Apr 11, 2019
    …nap implementation and drop the scroll-snap-type-{x,y} longhands.
    
    Now scroll-snap-type is a longhand property.
    
    Differential Revision: https://phabricator.services.mozilla.com/D21622
  2. style: Rename ScrollSnapType to ScrollSnapStrictness.

    hiikezoe authored and emilio committed Apr 11, 2019
    The scroll snap strictness is defined in the new spec [1], and the structure
    is the exactly same as the old scroll snap type structure.
    
    [1] https://drafts.csswg.org/css-scroll-snap-1/#snap-strictness
    
    Differential Revision: https://phabricator.services.mozilla.com/D21621
Commits on Mar 13, 2019
  1. style: Explicitly specify animation_value_type for scroll-padding.

    hiikezoe authored and emilio committed Feb 26, 2019
    Otherwise the Trait for clamping negative animation value isn't generated thus
    negative animating results are exposed in computed values.
    
    Differential Revision: https://phabricator.services.mozilla.com/D21153
Commits on Feb 24, 2019
  1. style: Implement scroll-margin parser and serializer.

    hiikezoe authored and emilio committed Feb 18, 2019
    The reason why we use  RelaxedAtomBool is that
    ScrollSnapUtils::GetSnapPointForDestination() is called both from the main and
    the compositor threads, and the function will have a branch depending on the
    pref value.
    
    Differential Revision: https://phabricator.services.mozilla.com/D20101
Commits on Jan 6, 2019
  1. style: Drop layout.css.background-blend-mode.enabled pref.

    hiikezoe authored and emilio committed Jan 4, 2019
    It was enabled by default in bug 970600.
    
    Differential Revision: https://phabricator.services.mozilla.com/D15708
  2. style: Drop layout.css.scroll-behavior.property-enabled pref.

    hiikezoe authored and emilio committed Jan 4, 2019
    It was enabled by default in bug 1041833 (for desktops) and
    bug 1087562 (for Fennec).
    
    Differential Revision: https://phabricator.services.mozilla.com/D15707
  3. style: Drop layout.css.mix-blend-mode.enabled pref.

    hiikezoe authored and emilio committed Jan 4, 2019
    It was enabled by default in bug 952643.
    
    Differential Revision: https://phabricator.services.mozilla.com/D15706
  4. style: Drop layout.css.isolation.enabled pref.

    hiikezoe authored and emilio committed Jan 4, 2019
    It was enabled by default in bug 1091885.
    
    Differential Revision: https://phabricator.services.mozilla.com/D15705
  5. style: Drop layout.css.image-orientation.enabled pref.

    hiikezoe authored and emilio committed Jan 4, 2019
    It was enabled by default in bug 825771.
    
    Differential Revision: https://phabricator.services.mozilla.com/D15704
  6. style: Drop layout.css.color-adjust.enabled pref.

    hiikezoe authored and emilio committed Jan 4, 2019
    It was enabled by default in bug 1209273.
    
    Depends on D15702
    
    Differential Revision: https://phabricator.services.mozilla.com/D15703
  7. style: Drop layout.css.box-decoration-break.enabled pref.

    hiikezoe authored and emilio committed Jan 4, 2019
    It was enabled by default in bug 1006326.
    
    Differential Revision: https://phabricator.services.mozilla.com/D15702
Commits on Dec 2, 2018
  1. style: Run background-color animations on the compositor.

    hiikezoe authored and emilio committed Nov 28, 2018
    Changes for nsIDOMWindowUtils.getOMTAValue is in the next commit with come test
    cases.
    
    Differential Revision: https://phabricator.services.mozilla.com/D13001
  2. style: Set the important rule change flag when a newly important rule…

    hiikezoe authored and emilio committed Nov 22, 2018
    … is inserted.
    
    Without this change an assertion checking IsInStyleRefresh() in
    EffectCompositor::PostRestyleForAnimation will be hit when we call
    FindAnimationsForCompositor from RestyleManager::DoProcessPendingRestyles
    that will be introduced in a subsequent commit in this series.
    
    I wrote a crash test which causes an assertion in KeyframeEffect::CanThrottle()
    without the subsequent commit, but we need more work in display item stuff to
    make the assertion won't happen (bug 1508466).
    
    Differential Revision: https://phabricator.services.mozilla.com/D12368
Commits on Sep 15, 2018
  1. style: Add media feature keys for hover and pointer.

    hiikezoe authored and emilio committed Aug 14, 2018
    https://drafts.csswg.org/mediaqueries-4/#hover
    https://drafts.csswg.org/mediaqueries-4/#pointer
    
    In this patch series, we don't introduce any-hover and any-pointer media
    features yet, but functionalities for them on each platform backends will be
    introduced in this patch series, so eIntID_AllPointerCapabilities and relevant
    stuff is added in this patch for the convenience that each platform backends
    can be reviewed at once.
    
    Differential Revision: https://phabricator.services.mozilla.com/D3296
Commits on Aug 7, 2018
  1. style: Introduce nsCSSKeywordAndBoolTableEntry.

    hiikezoe authored and emilio committed Jul 24, 2018
    The values in the boolean context depend on its feature.  For examples, in the
    case of prefers-reduced-motion 'no-preference' means false and 'reduced' mean
    true in the boolean context, whereas in the case of prefers-contrast
    'no-preference' means false and other two values, 'high' and 'low' means true
    in the boolean context.  To support it we introduce a child struct of
    nsCSSKTableEntry that has an additional field representing the value in the
    boolean context and use it when we have no specified value in the media feature
    (i.e. in the boolean context).
    
    Bug: 1365045
    Reviewed-by: heycam
    MozReview-Commit-ID: 79HiW8l5ous
Commits on Jun 30, 2018
  1. style: Try to allocate possible size for AnimationValueMap before com…

    hiikezoe authored and emilio committed Jun 26, 2018
    …posing.
    
    The EffectSet count does not exactly represent the count what we really need
    for AnimationValueMap, but in most cases it matches.  For example;
    
    1) The element has two different keyframes animations
    
     @Keyframes anim1 {
       to { opacity: 0; }
     }
     @Keyframes anim2 {
       to { transform: rotate(360deg); }
     }
    
     In this case the number matches.
    
    2) The element has two animations but both keyframes have the same CSS property
    
     @Keyframes anim1 {
       to { opacity: 0; }
     }
     @Keyframes anim2 {
       to { opacity: 0.1; }
     }
    
     In this case the number doesn't match, moreover it results more memory than we
     ever needed, but this case is presumably less common.
    
    3) The element has an animation having keyframes for two different CSS
       properties.
    
     @Keyframes anim {
       from { opacity: 0; transform: rotate(360deg); }
     }
    
     In this kind of cases, the number doesn't match.  But even so, this patch
     reduces the opportunities that the AnimationValueMap tries to allocate a new
     memory (i.e. less opportunities on expanding the map).
    
    Note that when the hash map is expanded, we do allocate a new RawTable with the
    new size then replace the old one with the new one [1], so I believe this
    change will reduce the crash rate to some extent.
    
    [1] https://hg.mozilla.org/mozilla-central/file/15c95df467be/servo/components/hashglobe/src/hash_map.rs#l734
    
    Bug: 1418806
    Reviewed-by: birtles
    MozReview-Commit-ID: 6tcF9aqXh7a
  2. style: Introduce a constant variable to represents the number of all …

    hiikezoe authored and emilio committed Jun 25, 2018
    …animatable longhands.
    
    We will use this number to cap the pre-allocation AnimationValueMap in the next
    patch.
    
    Bug: 1418806
    MozReview-Commit-ID: Iqq9plbD8Vl
Commits on Jun 18, 2018
  1. style: Double f64::EPSILON for calculation error.

    hiikezoe authored and emilio committed Jun 12, 2018
    It's possible that both this_weight and other_weght have calculation errors
    which are approximately equal to f64::EPSILON.
    
    Bug: 1468294
    Reviewed-by: birtles
    MozReview-Commit-ID: 8OddG9rI3qd
Commits on Jun 2, 2018
  1. style: Implement the smarter interporation for transform.

    hiikezoe authored and emilio committed May 29, 2018
    Corresponding to this spec change;
    w3c/csswg-drafts@3281266
    
    The expected value in test_transitions_per_property.html can be calculated;
    
      'start' + ('end' - 'start') * 0.25
    
    Bug: 1464647
    Reviewed-by: birtles, emilio
    MozReview-Commit-ID: NI9gOUuPnG
Commits on Apr 10, 2018
  1. Don't make logical properties animatable

    hiikezoe committed Apr 10, 2018
    |animation_type| was renamed in 94fb839, but the commit missed renaming
    one place.  It means that some of logical properties might have been
    accidentally animatable.  Logical properties should be animatable but we
    haven't yet implemented the proper Animate trait for logical properties.
Commits on Feb 21, 2018
  1. Update bindings.

    hiikezoe committed Feb 21, 2018
  2. Post DISPLAY_CHANGED_FROM_NONE sequential task if the display propert…

    hiikezoe committed Feb 21, 2018
    …y is changed from 'none' in the case the element has script animations
  3. Add a new sequential task flag for display propery changes from 'none'

    hiikezoe committed Feb 21, 2018
    Unlike CSS animations/transitions, script animations keep alive on display:none
    elements, so once the display property was changed to others in normal
    styling, we need to do styling for the script animations in the second
    animation traversal.  Otherwise, the styling for the script animations will
    be deferred to the next frame.
Commits on Jan 4, 2018
  1. Drop animation-name and transition-property from early properties

    hiikezoe committed Jan 4, 2018
    We don't need to calculate computed animation-name or transition-property prior
    to other properties any more because we no longer fill out those other
    properties values in response to animation-name or transition-property length
    at the time when we calculate computed property values.
  2. Check each animation sub property count in animations_equals

    hiikezoe committed Jan 4, 2018
    In a subsequent patch, we will no longer fill out deficient property values in
    mAnimations.
  3. Call transition_combined_duration_at to get combined duration instead…

    hiikezoe committed Jan 4, 2018
    … of calculating directly
  4. Make transition_combined_duration_at consider duration and delay valu…

    hiikezoe committed Jan 4, 2018
    …e are used by repeating the list of values if the given index is greater than the list length
Commits on Nov 22, 2017
  1. Update bindings.

    hiikezoe committed Nov 22, 2017
Older
You can’t perform that action at this time.