Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upMemory consumption keeps growing for no good reason (osx) #10029
Comments
|
This only happens with webrender for me. |
|
@paulrouget Can you run with |
Related: servo/servo#10029
No GC here apparently. |
Related: servo/servo#10029
Fix two leaks in the Mac platform code. Related: servo/servo#10029 r? @metajack
|
I tried https://gist.github.com/jdm/1d2e71157887849c7ba2 but didn't notice any difference in terms of memory usage when flailing my mouse around an instance of about-mozilla.html. That being said; I didn't notice unbounded memory usage either - it generally hovered between 90-105mb. |
|
@amccreight does the previous gist look like the hinting you were talking about? |
|
Yes, though I'm not too familiar with how it is actually supposed to be used. |
Addresses servo#10029.
Update ipc-channel to fix leaks and spurious ENOBUFS. Supersedes #10241 (fixes #10029). Also fixes #9555 (hopefully for good). <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10253) <!-- Reviewable:end -->
Update ipc-channel to fix leaks and spurious ENOBUFS. Supersedes #10241 (fixes #10029). Also fixes #9555 (hopefully for good). <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10253) <!-- Reviewable:end -->
|
We should verify the behaviour now. |
|
@paulrouget Want to try again? |
|
Moved the mouse for 20 seconds over the window. But I don't see any gc logs with |
|
I think we don't necessarily need GC heuristics here if dramatic memory increase isn't seen anymore, because a GC should happen once a lot of memory starts being used. Can we demote this issue to a lower priority level? |
Yes. As far as I am concerned, it's fixed. |
OSX.
Just moving the mouse hover the window makes the memory consumption grow.
Most likely this: rust-windowing/glutin#733