Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory consumption keeps growing for no good reason (osx) #10029

Closed
paulrouget opened this issue Mar 16, 2016 · 11 comments
Closed

Memory consumption keeps growing for no good reason (osx) #10029

paulrouget opened this issue Mar 16, 2016 · 11 comments

Comments

@paulrouget
Copy link
Contributor

@paulrouget paulrouget commented Mar 16, 2016

OSX.

Just moving the mouse hover the window makes the memory consumption grow.

Most likely this: rust-windowing/glutin#733

@kaksmet
Copy link
Contributor

@kaksmet kaksmet commented Mar 16, 2016

This only happens with webrender for me.

@pcwalton
Copy link
Contributor

@pcwalton pcwalton commented Mar 24, 2016

@paulrouget Can you run with -Z gc-profile and see if GCs are occurring? From my local tests it seems the issue is that we aren't GCing, and therefore mouse events are piling up.

@paulrouget
Copy link
Contributor Author

@paulrouget paulrouget commented Mar 24, 2016

@paulrouget Can you run with -Z gc-profile and see if GCs are occurring? From my local tests it seems the issue is that we aren't GCing, and therefore mouse events are piling up.

No GC here apparently.

pcwalton added a commit to pcwalton/ipc-channel that referenced this issue Mar 24, 2016
bors-servo added a commit to servo/ipc-channel that referenced this issue Mar 24, 2016
Fix two leaks in the Mac platform code.

Related: servo/servo#10029

r? @metajack
@jdm
Copy link
Member

@jdm jdm commented Mar 25, 2016

I tried https://gist.github.com/jdm/1d2e71157887849c7ba2 but didn't notice any difference in terms of memory usage when flailing my mouse around an instance of about-mozilla.html. That being said; I didn't notice unbounded memory usage either - it generally hovered between 90-105mb.

@jdm
Copy link
Member

@jdm jdm commented Mar 25, 2016

@amccreight does the previous gist look like the hinting you were talking about?

@amccreight
Copy link

@amccreight amccreight commented Mar 25, 2016

Yes, though I'm not too familiar with how it is actually supposed to be used.

pcwalton added a commit to pcwalton/servo that referenced this issue Mar 28, 2016
bors-servo added a commit that referenced this issue Mar 29, 2016
Update ipc-channel to fix leaks and spurious ENOBUFS.

Supersedes #10241 (fixes #10029).
Also fixes #9555 (hopefully for good).

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10253)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Mar 29, 2016
Update ipc-channel to fix leaks and spurious ENOBUFS.

Supersedes #10241 (fixes #10029).
Also fixes #9555 (hopefully for good).

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10253)
<!-- Reviewable:end -->
@jdm jdm reopened this Mar 29, 2016
@jdm
Copy link
Member

@jdm jdm commented Mar 29, 2016

We should verify the behaviour now.

@pcwalton
Copy link
Contributor

@pcwalton pcwalton commented Mar 29, 2016

@paulrouget Want to try again?

@paulrouget
Copy link
Contributor Author

@paulrouget paulrouget commented Mar 30, 2016

Moved the mouse for 20 seconds over the window.
Memory grew from 53.1Mb to 53.3Mb.
This is a lot better than before.

But I don't see any gc logs with -Z gc-profile.

@pcwalton
Copy link
Contributor

@pcwalton pcwalton commented Mar 30, 2016

I think we don't necessarily need GC heuristics here if dramatic memory increase isn't seen anymore, because a GC should happen once a lot of memory starts being used.

Can we demote this issue to a lower priority level?

@paulrouget
Copy link
Contributor Author

@paulrouget paulrouget commented Mar 31, 2016

Can we demote this issue to a lower priority level?

Yes. As far as I am concerned, it's fixed.

@jdm jdm closed this May 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

5 participants
You can’t perform that action at this time.