Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to successfully run the jQuery tests #10032

Open
1 of 2 tasks
sandlerr opened this issue Mar 16, 2016 · 2 comments
Open
1 of 2 tasks

Unable to successfully run the jQuery tests #10032

sandlerr opened this issue Mar 16, 2016 · 2 comments
Labels
A-testing

Comments

@sandlerr
Copy link

sandlerr commented Mar 16, 2016 •
edited by mbrubeck

Running this test ends in either of two unfavourable outcomes as per this gist.

The command run is RUST_BACKTRACE=1 ./mach test-jquery based off ad47c09.

  • The selector test reliably fails
  • the attributes test occasionally explodes.

Any advice on how to pin this down would be appreciated.
@Ms2ger Ms2ger mentioned this issue Mar 16, 2016
Merged
@Ms2ger
Copy link
Contributor

Ms2ger commented Mar 16, 2016

Fixed most of this in #10033; the panic might be #9202.

bors-servo pushed a commit that referenced this issue Mar 16, 2016
Auto merge of #10033 - Ms2ger:jquery, r=jdm
6c5bfca 
Make the jquery test runner work again.

CC #10032.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10033)
<!-- Reviewable:end -->
@sandlerr
Copy link
Author

Thanks @Ms2ger that certainly fixed the 50/4 issue.
I'm leaving this bug open since there are two others outstanding - the consistent failure of the selector test as well as the panic that looks similar to #9202 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mbrubeck @Ms2ger @sandlerr