Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upWhat is our popup story? #10056
What is our popup story? #10056
Comments
|
I don't understand why the bluetooth api looks at that. As for popups themselves: can we open new tabs from within Servo yet? We'll need to figure out a design for that, but that's more constellation than script. |
|
When that makes sense, we should delegate that to app itself, maybe via the browser api (when iframe are used):
|
|
As long as we don't end up with anything resembling the horror show that's Gecko window opening, I'm happy. |
|
Do we need to have some sort of sensible behavior if browser.html itself tries to show a modal popup? |
|
Yeah, that would be the same as some random website performing the same action in non-browser.html. |
|
In terms of Servo's current abilities, we have no support for multiple windows yet. IIRC miniservo-gtk supported multiple tabs by instantiating a new Constellation for each tab. CefBrowserHost::create_browser_sync seems to be the relevant code there, judging by ServoTab::init. |
|
We gave up on browserhtml. The new approach is to let the embedder know that it needs to show a popup. See the recent |
@dati91 is currently working on step #2 in http://webbluetoothcg.github.io/web-bluetooth/#requestDevice-secure-context, which can require a popup.
For now, we can clearly just assume that popups are never allowed, but I noticed that we don't currently have any issues on:
CC @jdm @Ms2ger