Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What is our popup story? #10056

Open
larsbergstrom opened this issue Mar 17, 2016 · 7 comments
Open

What is our popup story? #10056

larsbergstrom opened this issue Mar 17, 2016 · 7 comments
Labels

Comments

@larsbergstrom
Copy link
Contributor

@larsbergstrom larsbergstrom commented Mar 17, 2016

@dati91 is currently working on step #2 in http://webbluetoothcg.github.io/web-bluetooth/#requestDevice-secure-context, which can require a popup.

For now, we can clearly just assume that popups are never allowed, but I noticed that we don't currently have any issues on:

  1. Implementation of https://html.spec.whatwg.org/multipage/browsers.html#allowed-to-show-a-popup
  2. What should servo do for such popups?

CC @jdm @Ms2ger

@Ms2ger
Copy link
Contributor

@Ms2ger Ms2ger commented Mar 17, 2016

I don't understand why the bluetooth api looks at that.

As for popups themselves: can we open new tabs from within Servo yet? We'll need to figure out a design for that, but that's more constellation than script.

@Ms2ger
Copy link
Contributor

@Ms2ger Ms2ger commented Mar 17, 2016

As long as we don't end up with anything resembling the horror show that's Gecko window opening, I'm happy.

@notriddle
Copy link
Contributor

@notriddle notriddle commented Mar 18, 2016

Do we need to have some sort of sensible behavior if browser.html itself tries to show a modal popup?

@jdm
Copy link
Member

@jdm jdm commented Mar 18, 2016

Yeah, that would be the same as some random website performing the same action in non-browser.html.

@jdm
Copy link
Member

@jdm jdm commented Mar 18, 2016

In terms of Servo's current abilities, we have no support for multiple windows yet. IIRC miniservo-gtk supported multiple tabs by instantiating a new Constellation for each tab. CefBrowserHost::create_browser_sync seems to be the relevant code there, judging by ServoTab::init.

@paulrouget
Copy link
Contributor

@paulrouget paulrouget commented Jun 6, 2018

We gave up on browserhtml. The new approach is to let the embedder know that it needs to show a popup. See the recent alert implementation: #20707.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.