Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement NavigatorLanguage::languages #10073

Closed
Ms2ger opened this issue Mar 18, 2016 · 8 comments
Closed

Implement NavigatorLanguage::languages #10073

Ms2ger opened this issue Mar 18, 2016 · 8 comments

Comments

@Ms2ger
Copy link
Contributor

@Ms2ger Ms2ger commented Mar 18, 2016

Depends on #10072. (This implies we will not fix this issue in the near future.)

  • Spec: https://html.spec.whatwg.org/multipage/#navigatorlanguage.
  • Code: components/script/dom/webidls/Navigator.webidl, components/script/dom/navigator.rs, components/script/dom/webidls/WorkerNavigator.webidl, components/script/dom/workernavigator.rs.
  • Tests: to be written, as far as I know.
@craftytrickster
Copy link
Contributor

@craftytrickster craftytrickster commented Mar 22, 2016

Do you mind if I take this?

@jdm
Copy link
Member

@jdm jdm commented Mar 22, 2016

@craftytrickster See the first sentence of the original comment.

@craftytrickster
Copy link
Contributor

@craftytrickster craftytrickster commented Mar 22, 2016

@jdm I'm not familiar with your use of webidl, but can't this at least be partially implemented with a Vector?

@jdm
Copy link
Member

@jdm jdm commented Mar 22, 2016

For #10072 specifically, the main reason to hold off implementing it is that Gecko has not and the FrozenArray feature is really new.

@craftytrickster
Copy link
Contributor

@craftytrickster craftytrickster commented Mar 22, 2016

Thanks for the info, nevermind me taking this then :)

@nox
Copy link
Member

@nox nox commented Oct 1, 2017

This has yet to be implemented.

@nox
Copy link
Member

@nox nox commented Oct 1, 2017

And it's blocked by #10072.

@jdm
Copy link
Member

@jdm jdm commented Jul 14, 2020

Closing in favour of #27210. We don't support frozen arrays in our codegen yet, but we can manually return a frozen array.

@jdm jdm closed this Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.