Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In handle_navigate, revoke_paint_permission not called on the right pipeline #10162

Closed
paulrouget opened this issue Mar 24, 2016 · 1 comment
Closed

In handle_navigate, revoke_paint_permission not called on the right pipeline #10162

paulrouget opened this issue Mar 24, 2016 · 1 comment
Labels
A-constellation I-wrong

Comments

@paulrouget
Copy link
Contributor

@paulrouget paulrouget commented Mar 24, 2016

I'm not sure about this, could someone look at this and confirm my suspicions or explain to me why I'm wrong:

In handle_navigate_msg, frame.current is set to next (which is correct), and then we call revoke_paint_permission(prev) (which is correct), but within revoke_paint_permission, we use frame.current, which is not prev anymore. So revoke_paint_permission is never called on prev.
@paulrouget paulrouget mentioned this issue Mar 24, 2016
Closed
@paulrouget
Copy link
Contributor Author

@paulrouget paulrouget commented Sep 3, 2016

Things changed quite a lot since.
@paulrouget paulrouget closed this Sep 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-constellation I-wrong
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@mbrubeck @paulrouget
You can’t perform that action at this time.