Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: background images painted only after reflow #10163

Closed
paulrouget opened this issue Mar 24, 2016 · 0 comments
Closed

regression: background images painted only after reflow #10163

paulrouget opened this issue Mar 24, 2016 · 0 comments
Assignees

Comments

@paulrouget
Copy link
Contributor

@paulrouget paulrouget commented Mar 24, 2016

The follow page only turns red after a reflow (resizing the window for example):

<style>
  body {
    width: 100px;
    height: 100px;
    background-image: url('data:image/gif;base64,R0lGODlhAQABAPAAAP8REf///yH5BAAAAAAALAAAAAABAAEAAAICRAEAOw==');
  }
</style>

It's a regression, and I believe it might be because of #10021. See #10021 (comment).

@mbrubeck mbrubeck changed the title regression: images painted only after reflow regression: background images painted only after reflow Mar 25, 2016
@mbrubeck mbrubeck self-assigned this Mar 25, 2016
mbrubeck added a commit to mbrubeck/servo that referenced this issue Mar 25, 2016
After servo#10021, `LayoutThread::repaint` no longer forced a repaint because of
the `restyle_damage` check.  This patch adds the correct restyle damage and
fixes servo#10163.
bors-servo added a commit that referenced this issue Mar 25, 2016
Fix forced repaint on image load

After #10021, `LayoutThread::repaint` no longer forced a repaint because of the `restyle_damage` check.  This patch adds the correct restyle damage and fixes #10163.

r? @pcwalton

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10197)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants
You can’t perform that action at this time.