Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use rustflags #10193

Merged
merged 3 commits into from Mar 25, 2016
Merged

Use rustflags #10193

merged 3 commits into from Mar 25, 2016

Conversation

larsbergstrom
Copy link
Contributor

r? @Ms2ger

This change is Reviewable

@highfive
Copy link

Heads up! This PR modifies the following files:

  • @wafflespeanut: python/servo/command_base.py, python/servo/build_commands.py

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Mar 25, 2016
@Ms2ger
Copy link
Contributor

Ms2ger commented Mar 25, 2016

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit e83369d has been approved by Ms2ger

@bors-servo
Copy link
Contributor

⌛ Testing commit e83369d with merge a211bd1...

bors-servo pushed a commit that referenced this pull request Mar 25, 2016
Auto merge of #10193 - larsbergstrom:use_rustflags, r=Ms2ger
a211bd1 
Use rustflags

r? @Ms2ger

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10193)
<!-- Reviewable:end -->
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Mar 25, 2016
@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, gonk, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, status-appveyor

@bors-servo bors-servo merged commit e83369d into servo:master Mar 25, 2016
@mbrubeck
Copy link
Contributor

mbrubeck commented Apr 20, 2016 •
edited

@larsbergstrom: The default target features for Rust's built-in ARMv7 targets (e.g. armv7-apple-ios) are "+v7,+vfp3,+neon". Have we tested with these additional flags too?

@mbrubeck
Copy link
Contributor

Filed rust-lang/rust#33115.

@larsbergstrom larsbergstrom deleted the use_rustflags branch September 29, 2016 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Ms2ger Ms2ger

Labels
S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@larsbergstrom @highfive @Ms2ger @bors-servo @mbrubeck