Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement CSS Transition Events (transitionend) #10245

Closed
mbrubeck opened this issue Mar 28, 2016 · 9 comments
Closed

Implement CSS Transition Events (transitionend) #10245

mbrubeck opened this issue Mar 28, 2016 · 9 comments

Comments

@mbrubeck
Copy link
Contributor

@mbrubeck mbrubeck commented Mar 28, 2016

https://drafts.csswg.org/css-transitions/#transition-events

Aside from web compatibility, this is also important for writing reliable automated tests that use transitions.

bors-servo added a commit that referenced this issue Mar 29, 2016
Restore stripped whitespace before reflowing text fragments

Fixes #10200. r? @pcwalton

Note: The reftest uses a transition of non-zero duration, because I couldn't find any other way to reproduce the bug.  Unfortunately this makes it unreliable in debug builds. I tried to fix this using reftest-wait with setTimeout and requestAnimationFrame, but it still wouldn't complete the animation consistently.  To make the test work in debug builds we may need `transitionend` events (#10245) or a different way to reproduce the bug.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10246)
<!-- Reviewable:end -->
@saurvs
Copy link
Contributor

@saurvs saurvs commented Apr 3, 2016

I'm working on this.

@jdm
Copy link
Member

@jdm jdm commented Apr 4, 2016

For what it's worth, places to start looking for the actual transition-related code:

  • // Finish any expired transitions.
    seems to be code that deals with determining if an animation is finished
  • we would need to add a way to send messages to the script thread (maybe like the animations_sender member of SharedStyleContext) with a pipeline, node, and event type - this message would cause a new event of the desired type to be dispatched at the target node that is inside the document associated with the given pipeline
  • pub fn start_transitions_if_applicable<C: ComputedValues>(new_animations_sender: &Mutex<Sender<Animation>>,
    might be a good place to a add similar message for starting a transition (this might not be necessary; I haven't read the specification)
@saurvs
Copy link
Contributor

@saurvs saurvs commented Apr 4, 2016

The spec says that only the completion of a css transition generates a corresponding dom event.

@jdm
Copy link
Member

@jdm jdm commented Apr 13, 2016

Unassigning under the assumption that this is not being worked on given the lack of response in #10393.

@jdm jdm added the C-assigned label Apr 14, 2016
@jdm
Copy link
Member

@jdm jdm commented Apr 14, 2016

@saurvs indicated that they're continuing to work on this.

@KiChjang
Copy link
Member

@KiChjang KiChjang commented Jun 16, 2016

@saurvs Is this still being worked on?

@saurvs
Copy link
Contributor

@saurvs saurvs commented Jun 16, 2016

@KiChjang I was busy for a while. I'd like to finish it now.

@KiChjang
Copy link
Member

@KiChjang KiChjang commented Aug 1, 2016

@saurvs What's the status of this?

@saurvs
Copy link
Contributor

@saurvs saurvs commented Aug 3, 2016

@KiChjang Sorry, I'd couldn't figure out the surrounding code for sending the event, and can't make progress. I hope my code about the DOM of the transition event #10393 is useful.

@jdm jdm removed the C-assigned label Aug 3, 2016
@KiChjang KiChjang self-assigned this Aug 4, 2016
@KiChjang KiChjang added the C-assigned label Aug 4, 2016
bors-servo added a commit that referenced this issue Aug 26, 2016
Implement transition event and infrastructure

Fixes #10245.
bors-servo added a commit that referenced this issue Aug 26, 2016
Implement transition event and infrastructure

Fixes #10245.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13056)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Aug 26, 2016
Implement transition event and infrastructure

Fixes #10245.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13056)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Aug 26, 2016
Implement transition event and infrastructure

Fixes #10245.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13056)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Sep 3, 2016
Implement transition event and infrastructure

Fixes #10245.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13056)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Sep 3, 2016
Implement transition event and infrastructure

Fixes #10245.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13056)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Sep 4, 2016
Implement transition event and infrastructure

Fixes #10245.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13056)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Sep 4, 2016
Implement transition event and infrastructure

Fixes #10245.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13056)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Sep 10, 2016
Implement transition event and infrastructure

Fixes #10245.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13056)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Sep 10, 2016
Implement transition event and infrastructure

Fixes #10245.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13056)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Sep 11, 2016
Implement transition event and infrastructure

Fixes #10245.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13056)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Sep 11, 2016
Implement transition event and infrastructure

Fixes #10245.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13056)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Oct 11, 2016
Implement transition event and infrastructure

Fixes #10245.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13056)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Oct 12, 2016
Implement transition event and infrastructure

Fixes #10245.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13056)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Oct 12, 2016
Implement transition event and infrastructure

Fixes #10245.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13056)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Oct 12, 2016
Implement transition event and infrastructure

Fixes #10245.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13056)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Oct 12, 2016
Implement transition event and infrastructure

Fixes #10245.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13056)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.