Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upImplement CSS Transition Events (transitionend) #10245
Comments
Restore stripped whitespace before reflowing text fragments Fixes #10200. r? @pcwalton Note: The reftest uses a transition of non-zero duration, because I couldn't find any other way to reproduce the bug. Unfortunately this makes it unreliable in debug builds. I tried to fix this using reftest-wait with setTimeout and requestAnimationFrame, but it still wouldn't complete the animation consistently. To make the test work in debug builds we may need `transitionend` events (#10245) or a different way to reproduce the bug. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10246) <!-- Reviewable:end -->
|
I'm working on this. |
|
For what it's worth, places to start looking for the actual transition-related code:
|
|
The spec says that only the completion of a css transition generates a corresponding dom event. |
|
Unassigning under the assumption that this is not being worked on given the lack of response in #10393. |
|
@saurvs indicated that they're continuing to work on this. |
|
@saurvs Is this still being worked on? |
|
@KiChjang I was busy for a while. I'd like to finish it now. |
|
@saurvs What's the status of this? |
Implement transition event and infrastructure Fixes #10245. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13056) <!-- Reviewable:end -->
Implement transition event and infrastructure Fixes #10245. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13056) <!-- Reviewable:end -->
Implement transition event and infrastructure Fixes #10245. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13056) <!-- Reviewable:end -->
Implement transition event and infrastructure Fixes #10245. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13056) <!-- Reviewable:end -->
Implement transition event and infrastructure Fixes #10245. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13056) <!-- Reviewable:end -->
Implement transition event and infrastructure Fixes #10245. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13056) <!-- Reviewable:end -->
Implement transition event and infrastructure Fixes #10245. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13056) <!-- Reviewable:end -->
Implement transition event and infrastructure Fixes #10245. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13056) <!-- Reviewable:end -->
Implement transition event and infrastructure Fixes #10245. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13056) <!-- Reviewable:end -->
Implement transition event and infrastructure Fixes #10245. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13056) <!-- Reviewable:end -->
Implement transition event and infrastructure Fixes #10245. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13056) <!-- Reviewable:end -->
Implement transition event and infrastructure Fixes #10245. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13056) <!-- Reviewable:end -->
Implement transition event and infrastructure Fixes #10245. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13056) <!-- Reviewable:end -->
Implement transition event and infrastructure Fixes #10245. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13056) <!-- Reviewable:end -->
Implement transition event and infrastructure Fixes #10245. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13056) <!-- Reviewable:end -->
Implement transition event and infrastructure Fixes #10245. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13056) <!-- Reviewable:end -->
https://drafts.csswg.org/css-transitions/#transition-events
Aside from web compatibility, this is also important for writing reliable automated tests that use transitions.