Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove CompositorThread struct? #10261
Closed
Comments
|
CC #11339 |
|
This code can be removed: https://github.com/mbrubeck/servo/blob/master/components/compositing/compositor_thread.rs#L286-L296 and the code that calls it can call |
|
I will take a shot at this issue! |
|
@talklittle have at it! |
|
@talklittle also #11443 took care of removing the boxed trait object, so you do not need to worry about that. |
bors-servo
added a commit
that referenced
this issue
Jun 3, 2016
compositing: Remove CompositorThread struct <!-- Please describe your changes on the following line: --> Remove `CompositorThread` struct, since it wraps only `IOCompositor`. Use `IOCompositor` directly. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #10261 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [X] These changes do not require tests because refactoring <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11569) <!-- Reviewable:end -->
bors-servo
added a commit
that referenced
this issue
Jun 3, 2016
compositing: Remove CompositorThread struct <!-- Please describe your changes on the following line: --> Remove `CompositorThread` struct, since it wraps only `IOCompositor`. Use `IOCompositor` directly. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #10261 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [X] These changes do not require tests because refactoring <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11569) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This now unconditionally wraps
IOCompositor. (\o/)