Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a script_runtime module #10271

Closed
Ms2ger opened this issue Mar 29, 2016 · 2 comments
Closed

Create a script_runtime module #10271

Ms2ger opened this issue Mar 29, 2016 · 2 comments
Labels
A-content/dom C-assigned E-easy I-refactor

Comments

@Ms2ger
Copy link
Contributor

@Ms2ger Ms2ger commented Mar 29, 2016

script_thread.rs contains the implementation of the main script thread (where Windows/Documents live), as well as a number of things that are shared between that thread and web worker threads (dedicatedworkerglobalscope.rs and workerglobalscope.rs). In particular:

  • ScriptThread::new_rt_and_cx
  • ScriptThread::get_reports
  • ScriptChan
  • ScriptPort
  • StackRootTLS
  • CommonScriptMsg
  • ScriptThreadEventCategory

All of those should move to a new file (components/script/script_runtime.rs).
@creativcoder
Copy link
Contributor

@creativcoder creativcoder commented Mar 29, 2016

Ill take that.
@jdm jdm added the C-assigned label Mar 29, 2016
@jdm
Copy link
Member

@jdm jdm commented Mar 29, 2016

Go for it!
@creativcoder creativcoder mentioned this issue Apr 1, 2016
Merged
bors-servo added a commit that referenced this issue Apr 6, 2016
@bors-servo
Auto merge of #10342 - creativcoder:script-runtime-module, r=Ms2ger
Loading status checks…
883cde4 
Refactors some entities from script_thread into script_runtime

Fixes #10271.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10342)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-content/dom C-assigned E-easy I-refactor
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@jdm @Ms2ger @creativcoder
You can’t perform that action at this time.