Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement URL.searchParams #10335

Closed
paulrouget opened this issue Apr 1, 2016 · 4 comments
Closed

Implement URL.searchParams #10335

paulrouget opened this issue Apr 1, 2016 · 4 comments
Labels
C-assigned E-easy

Comments

@paulrouget
Copy link
Contributor

@paulrouget paulrouget commented Apr 1, 2016

servo/components/script/dom/webidls/URL.webidl

Line 23 in f335586

// readonly attribute URLSearchParams searchParams;

https://url.spec.whatwg.org/#interface-urlsearchparams
@paulrouget paulrouget mentioned this issue Apr 1, 2016
Merged
@Manishearth Manishearth added the E-easy label Apr 1, 2016
@Manishearth
Copy link
Member

@Manishearth Manishearth commented Apr 1, 2016

This should be useful here: http://doc.servo.org/url/struct.Url.html#method.query_pairs
@stjepang
Copy link
Contributor

@stjepang stjepang commented Apr 1, 2016

Can I try this?
@paulrouget
Copy link
Contributor Author

@paulrouget paulrouget commented Apr 1, 2016

Sure!
@Manishearth
Copy link
Member

@Manishearth Manishearth commented Apr 1, 2016

Let us know if you need help!
@stjepang stjepang mentioned this issue Apr 1, 2016
Merged
bors-servo added a commit that referenced this issue Apr 5, 2016
@bors-servo
Auto merge of #10351 - stjepang:impl-url-searchparams, r=Manishearth
Loading status checks…
4eb1915 
Implement URL.searchParams

Spec: https://url.spec.whatwg.org/#dom-url-searchparams
Closes #10335.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10351)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Apr 5, 2016
@bors-servo
Auto merge of #10351 - stjepang:impl-url-searchparams, r=Manishearth
Loading status checks…
664bfea 
Implement URL.searchParams

Spec: https://url.spec.whatwg.org/#dom-url-searchparams
Closes #10335.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10351)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Apr 5, 2016
@bors-servo
Auto merge of #10351 - stjepang:impl-url-searchparams, r=Manishearth
Loading status checks…
a2deaa8 
Implement URL.searchParams

Spec: https://url.spec.whatwg.org/#dom-url-searchparams
Closes #10335.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10351)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Apr 5, 2016
@bors-servo
Auto merge of #10351 - stjepang:impl-url-searchparams, r=Manishearth
Loading status checks…
7d05445 
Implement URL.searchParams

Spec: https://url.spec.whatwg.org/#dom-url-searchparams
Closes #10335.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10351)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Apr 6, 2016
@bors-servo
Auto merge of #10351 - stjepang:impl-url-searchparams, r=Manishearth
Loading status checks…
e36e3be 
Implement URL.searchParams

Spec: https://url.spec.whatwg.org/#dom-url-searchparams
Closes #10335.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10351)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-assigned E-easy
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@paulrouget @stjepang @Manishearth
You can’t perform that action at this time.