Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAndroid nightly failing again #10339
Comments
|
Thanks! I think this is just a failure to run the android |
|
My first guess would be that the menu entries in the output of Have there been any changes on the Android builders lately? |
|
I just ssh'ed into However, this shouldn't matter - the proper SDK should already be installed from whenever we set up the builder. |
|
Aha! I think that we somewhat-recently upgraded SDK & NDK versions, because I remember having to propagate the changes to the environment variables. I think that happened with the old builders (which would already have had the original SDKs installed) and now when we provisioned the new ones, the new bits were not installed. |
|
Nope, checking in the I'll put in a PR for a quick fix, but I'll need to rejigger these states to work better long term. |
|
You're right, I bumped the SDK version in November. Maybe I don't need to fix the states after all. Are these the first Android builds we've run on the new builders? I'm surprised we haven't had any other failures since moving to the cross builders. |
|
I think that the rest of the Android stuff is somehow working fine (it got the platform). The nightly build has been broken since the move, though, because though the platform is there the platform build tools are not. Those are only used in the android-nightly build - the others just need the headers to link against, etc. |
|
In fact, I think we only need the NDK for the rest of the Servo android build! It's only when we build the packaging and java library goop that we touch anything from the SDK. |
…24, r=larsbergstrom Update android-18 menu entry to 8 for SDK r24 We're ignoring Travis builds for the cross builder and this fix needs to be verified in Vagrant (this VM takes a while to provision unfortunately). We may want to actually try running a build in Vagrant to see if this works. We updated to Android SDK r24 in November from r23, but did not update the menu entry to install the android-18 target. The new number comes from the output of `./android sdk list`. We need to delete the `/home/servo/android/sdk/r24.4.1` folder before applying this fix to the builders. Ideally this would get checked for by Salt, but currently you can only specify one file for the ` - creates: ` key of `cmd.run`, and our state creates the `platform-tools` dir and the `android-18` dir. I'll open a Salt issue for this. cc @larsbergstrom, servo/servo#10339 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/290) <!-- Reviewable:end -->
|
servo/saltfs#290 landed and seems to have fixed the compile step: http://build.servo.org/builders/android-nightly/builds/57. Looking into the other failures now. |
…brubeck Fix Android APK building (packaging) Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy --faster` does not report any errors - [ ] These changes help with #10339. Either: - [x] There are tests for these changes (android-nightly builder) OR - [ ] These changes do not require tests because _____ Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. I missed this syntax error during my review, and we don't check that packaging succeeds in regular build suite, but only as a Nightly build. @larsbergstrom should we run the packaging as part of the regular build? I think it is important that this continue to stay working, especially with #9918. In that case, the only difference with the nightly builder is whether or not to upload to S3. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11406) <!-- Reviewable:end -->
Install Android build tools for cross compilation The Android build tools are required for building an APK. They are versioned separately from the SDK and do not have a version requirement - best practice is to use the latest (stable) release. After servo/servo#11406 landed, I forced an android-nightly build, which now gets further but still fails. The new failure is http://build.servo.org/builders/android-nightly/builds/60/steps/shell_1/logs/stdio, so install the build tools to fix this. Edit: relevant error for posterity: ``` BUILD FAILED /home/servo/android/sdk/current/tools/ant/build.xml:483: SDK does not have any Build Tools installed. ``` Another step for servo/servo#10339. I think this would benefit from #374 - I had a lot of errors trying to get the android tool to install the build tools where blowing away the directory fixed it. I think the --all parameter should take care of it, but I'd like to be more sure. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/388) <!-- Reviewable:end -->
…larsbergstrom Add --android option to ./mach package servo/servo#11210 recently updated `./mach package` to make it a first-class Mach command and add support for simple Linux packaging as well (in the form of tarballs). Android used to be the only packaging target supported, so a naked `./mach package` sufficed, but now we need to explicitly build the Android packaging. Another step for servo/servo#10339. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/401) <!-- Reviewable:end -->
|
This is working now: http://build.servo.org/builders/android-nightly/builds/96 |
CC @larsbergstrom