New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix some char/byte bugs in textinput #10350
Conversation
Heads up! This PR modifies the following files:
|
2027621
to
4ae2741
Compare
The HTML spec for the |
Ugh. |
4ae2741
to
0822e22
Compare
Fixed to use UTF-16 code units for max_length. |
0822e22
to
f121a5b
Compare
Reviewed 1 of 2 files at r5, 1 of 1 files at r6. components/script/textinput.rs, line 214 [r6] (raw file): components/script/textinput.rs, line 333 [r6] (raw file): components/script/textinput.rs, line 533 [r6] (raw file): tests/unit/script/textinput.rs, line 138 [r6] (raw file): Comments from Reviewable |
f121a5b
to
deca979
Compare
Review status: all files reviewed at latest revision, 4 unresolved discussions. components/script/textinput.rs, line 214 [r6] (raw file): components/script/textinput.rs, line 333 [r6] (raw file): components/script/textinput.rs, line 533 [r6] (raw file): tests/unit/script/textinput.rs, line 138 [r6] (raw file): Comments from Reviewable |
@bors-servo r+ Reviewed 3 of 3 files at r7. Comments from Reviewable |
📌 Commit deca979 has been approved by |
⌛ Testing commit deca979 with merge c0bfcc5... |
Fix some char/byte bugs in textinput Fixes #9569. r? @SimonSapin or @Ms2ger <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10350) <!-- Reviewable:end -->
☀️ Test successful - android, arm32, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, status-appveyor |
Fixes #9569. r? @SimonSapin or @Ms2ger
This change is