Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update crates that use byteorder to use 0.5 #10437

Closed
emilio opened this issue Apr 6, 2016 · 14 comments
Closed

Update crates that use byteorder to use 0.5 #10437

emilio opened this issue Apr 6, 2016 · 14 comments
Labels
E-easy I-cleanup I-perf-bloat

Comments

@emilio
Copy link
Member

@emilio emilio commented Apr 6, 2016

As discussed in #10433 (comment).

Crates with the old dependency include:

  • bincode
  • image
  • immeta
  • ipc-channel
  • jpeg-decoder
  • wayland-window
  • websocket

cc @saurvs
@emilio emilio mentioned this issue Apr 6, 2016
Merged
@kaksmet
Copy link
Contributor

@kaksmet kaksmet commented Apr 6, 2016

jpeg-decoder 0.1.3 (which uses byteorder 0.5) has been published.
@jaysonsantos
Copy link

@jaysonsantos jaysonsantos commented Apr 11, 2016

immeta 0.3.2 is published with new version
@jaysonsantos
Copy link

@jaysonsantos jaysonsantos commented Apr 11, 2016

Image already merged on image-rs/image#525 I just asked if they have an ETA
@jaysonsantos
Copy link

@jaysonsantos jaysonsantos commented Apr 11, 2016

wayland-window 0.2.3is also published with new byteorder
@jaysonsantos
Copy link

@jaysonsantos jaysonsantos commented Apr 12, 2016

rust-websocket 0.16.2 also published with new byteorder
@jaysonsantos
Copy link

@jaysonsantos jaysonsantos commented Apr 12, 2016

image 0.9.0 also done
@jaysonsantos
Copy link

@jaysonsantos jaysonsantos commented Apr 12, 2016

bincode 0.5.3 done
@jaysonsantos
Copy link

@jaysonsantos jaysonsantos commented Apr 12, 2016

servo/ipc-channel is ok on master, who could generate a new version of it?
@jdm
Copy link
Member

@jdm jdm commented Apr 12, 2016

Opened servo/ipc-channel#65. Will publish when it's merged.
@jdm
Copy link
Member

@jdm jdm commented Apr 12, 2016

Apparently we use ipc-channel via git, so it should now be possible to update all of the crates to the newest versions.
@jaysonsantos
Copy link

@jaysonsantos jaysonsantos commented Apr 12, 2016

Nice
@jdm
Copy link
Member

@jdm jdm commented Apr 12, 2016

Note for anybody doing this: ./mach cargo-update -p library_name is the correct way to upgrade.
@saurvs
Copy link
Contributor

@saurvs saurvs commented Apr 13, 2016

I can update the lock files and remove the exception for byteorder from tidy.py
@saurvs saurvs mentioned this issue Apr 13, 2016
Merged
bors-servo added a commit that referenced this issue Apr 13, 2016
@bors-servo
Auto merge of #10565 - saurvs:master, r=Ms2ger
Loading status checks…
d566f1c 
Update to byteorder 0.5

Finishes #10437.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10565)
<!-- Reviewable:end -->
@jdm
Copy link
Member

@jdm jdm commented Apr 13, 2016

Fixed by #10565.
@jdm jdm closed this Apr 13, 2016
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this issue Oct 1, 2019
@marco-c
servo: Merge #10565 - Update to byteorder 0.5 (from saurvs:master); r…
655db08 
…=Ms2ger

Finishes servo/servo#10437.

Source-Repo: https://github.com/servo/servo
Source-Revision: d566f1c143e051b3c3d4ff9e9d8087af8b45dbd6

UltraBlame original commit: 80585f49bc0ff711f662fc5725f767f705582826
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this issue Oct 1, 2019
@marco-c
servo: Merge #10565 - Update to byteorder 0.5 (from saurvs:master); r…
023bbb1 
…=Ms2ger

Finishes servo/servo#10437.

Source-Repo: https://github.com/servo/servo
Source-Revision: d566f1c143e051b3c3d4ff9e9d8087af8b45dbd6

UltraBlame original commit: 80585f49bc0ff711f662fc5725f767f705582826
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this issue Oct 1, 2019
@marco-c
servo: Merge #10565 - Update to byteorder 0.5 (from saurvs:master); r…
dad99b8 
…=Ms2ger

Finishes servo/servo#10437.

Source-Repo: https://github.com/servo/servo
Source-Revision: d566f1c143e051b3c3d4ff9e9d8087af8b45dbd6

UltraBlame original commit: 80585f49bc0ff711f662fc5725f767f705582826
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E-easy I-cleanup I-perf-bloat
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
@jdm @jaysonsantos @emilio @kaksmet @saurvs
You can’t perform that action at this time.