Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block formatting contexts should never collapse margins #10449

Closed
pcwalton opened this issue Apr 7, 2016 · 0 comments
Closed

Block formatting contexts should never collapse margins #10449

pcwalton opened this issue Apr 7, 2016 · 0 comments
Labels
A-layout/block I-wrong An incorrect behaviour is observed.

Comments

@pcwalton
Copy link
Contributor

pcwalton commented Apr 7, 2016

Here is a test case:

<style>

  main {
    height: 300px;
    width: 250px;
    background-image: linear-gradient(to bottom, red, blue);
    overflow: scroll;
  }

  div {
    margin-top: 200px;
    height: 200px;
    width: 200px;
    overflow: scroll;
  }

  p {
    height: 250px;
    background-image: linear-gradient(to bottom, white, black);
    margin: 0;
  }

</style>
<main>
  <div>
    <p></p>
  </div>
</main>

cc @paulrouget

@pcwalton pcwalton added I-wrong An incorrect behaviour is observed. A-layout/block A-browserhtml/P1 labels Apr 7, 2016
@pcwalton pcwalton changed the title Overflow regions don't take vertical margins into account Block formatting contexts should never collapse margins Apr 7, 2016
pcwalton added a commit to pcwalton/servo that referenced this issue Apr 7, 2016
pcwalton added a commit to pcwalton/servo that referenced this issue Apr 7, 2016
bors-servo pushed a commit that referenced this issue Apr 7, 2016
…pse, r=mbrubeck

layout: Disallow margins from collapsing through block formatting contexts per CSS 2.1 § 8.3.1.

Closes #10449.

r? @mbrubeck

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10458)
<!-- Reviewable:end -->
pcwalton added a commit to pcwalton/servo that referenced this issue Apr 8, 2016
pcwalton added a commit to pcwalton/servo that referenced this issue Apr 8, 2016
pcwalton added a commit to pcwalton/servo that referenced this issue Apr 12, 2016
bors-servo pushed a commit that referenced this issue Apr 12, 2016
…pse, r=mbrubeck

layout: Disallow margins from collapsing through block formatting contexts per CSS 2.1 § 8.3.1.

Closes #10449.

r? @mbrubeck

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10458)
<!-- Reviewable:end -->
pcwalton added a commit to pcwalton/servo that referenced this issue Apr 14, 2016
pcwalton added a commit to pcwalton/servo that referenced this issue Apr 14, 2016
bors-servo pushed a commit that referenced this issue Apr 14, 2016
…pse, r=mbrubeck

layout: Disallow margins from collapsing through block formatting contexts per CSS 2.1 § 8.3.1.

Closes #10449.

r? @mbrubeck

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10458)
<!-- Reviewable:end -->
pcwalton added a commit to pcwalton/servo that referenced this issue Apr 14, 2016
bors-servo pushed a commit that referenced this issue Apr 14, 2016
…pse, r=mbrubeck

layout: Disallow margins from collapsing through block formatting contexts per CSS 2.1 § 8.3.1.

Closes #10449.

r? @mbrubeck

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10458)
<!-- Reviewable:end -->
pcwalton added a commit to pcwalton/servo that referenced this issue Apr 14, 2016
bors-servo pushed a commit that referenced this issue Apr 14, 2016
…pse, r=mbrubeck

layout: Disallow margins from collapsing through block formatting contexts per CSS 2.1 § 8.3.1.

Closes #10449.

r? @mbrubeck

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10458)
<!-- Reviewable:end -->
pcwalton added a commit to pcwalton/servo that referenced this issue Apr 15, 2016
bors-servo pushed a commit that referenced this issue Apr 15, 2016
…pse, r=mbrubeck

layout: Disallow margins from collapsing through block formatting contexts per CSS 2.1 § 8.3.1.

Closes #10449.

r? @mbrubeck

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10458)
<!-- Reviewable:end -->
asajeffrey pushed a commit to asajeffrey/servo that referenced this issue Apr 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-layout/block I-wrong An incorrect behaviour is observed.
Projects
None yet
Development

No branches or pull requests

1 participant