Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reflect HTMLInputElement content attributes #10491

Closed
KiChjang opened this issue Apr 8, 2016 · 4 comments
Closed

Reflect HTMLInputElement content attributes #10491

KiChjang opened this issue Apr 8, 2016 · 4 comments
Assignees
@KiChjang
Labels
A-content/dom C-assigned I-enhancement

Comments

@KiChjang
Copy link
Member

@KiChjang KiChjang commented Apr 8, 2016

There is a slew of IDL attributes on HTMLInputElement which simply requires a setter and getter defined on them.

Spec: https://html.spec.whatwg.org/multipage/forms.html#dom-input-accept
Code: components/script/dom/htmlinputelement.rs, components/script/webidls/HTMLInputElement.webidl
@amarant
Copy link
Contributor

@amarant amarant commented Apr 8, 2016

I volunteer to take it.
@KiChjang
Copy link
Member Author

@KiChjang KiChjang commented Apr 8, 2016

Of course!
@KiChjang KiChjang added the C-assigned label Apr 8, 2016
amarant added a commit to amarant/string-cache that referenced this issue Apr 9, 2016
@amarant
add dirname atom for HTMLInputElement attribute
8052967 
related to servo issue : servo/servo#10491
@amarant amarant mentioned this issue Apr 9, 2016
Merged
bors-servo added a commit to servo/string-cache that referenced this issue Apr 9, 2016
@bors-servo
Auto merge of #148 - amarant:add-dirname, r=frewsxcv
Loading status checks…
5399a9f 
add dirname atom for HTMLInputElement attribute

related to servo issue : servo/servo#10491

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/string-cache/148)
<!-- Reviewable:end -->
amarant added a commit to amarant/servo that referenced this issue Apr 9, 2016
@amarant
Issue servo#10491 add HTMLInputElement attributes that reflect conten…
b416d7c 
…t identically

it uses a new version of string-cache servo/string-cache#148
amarant added a commit to amarant/servo that referenced this issue Apr 9, 2016
@amarant
Issue servo#10491 add HTMLInputElement attributes that reflect conten…
b35df61 
…t identically

it uses a new version of string-cache servo/string-cache#148
amarant added a commit to amarant/servo that referenced this issue Apr 9, 2016
@amarant
Issue servo#10491 add HTMLInputElement attributes that reflect conten…
f280e39 
…t identically

it uses a new version of string-cache servo/string-cache#148
amarant added a commit to amarant/servo that referenced this issue Apr 9, 2016
@amarant
Issue servo#10491 add HTMLInputElement attributes that reflect conten…
90c25cf 
…t identically

it uses a new version of string-cache servo/string-cache#148
amarant added a commit to amarant/servo that referenced this issue Apr 10, 2016
@amarant
Issue servo#10491 add HTMLInputElement attributes that reflect conten…
cd57f54 
…t identically

it uses a new version of string-cache servo/string-cache#148
bors-servo added a commit that referenced this issue Apr 10, 2016
@bors-servo
Auto merge of #10505 - amarant:10491-HTMLInputElement-attr, r=KiChjang
Loading status checks…
b8de0b6 
Issue #10491 add HTMLInputElement attributes that reflect content ide…

…ntically

it uses a new version of string-cache servo/string-cache#148

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10505)
<!-- Reviewable:end -->
amarant added a commit to amarant/servo that referenced this issue Apr 11, 2016
@amarant
Issue servo#10491 add HTMLInputElement attributes that reflect conten…
281115b 
…t identically

it uses a new version of string-cache servo/string-cache#148
amarant added a commit to amarant/servo that referenced this issue Apr 11, 2016
@amarant
Issue servo#10491 add HTMLInputElement attributes that reflect conten…
9b8f183 
…t identically

it uses a new version of string-cache servo/string-cache#148
bors-servo added a commit that referenced this issue Apr 12, 2016
@bors-servo
Auto merge of #10505 - amarant:10491-HTMLInputElement-attr, r=KiChjang
Loading status checks…
61865f6 
Issue #10491 add HTMLInputElement attributes that reflect content ide…

…ntically

it uses a new version of string-cache servo/string-cache#148

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10505)
<!-- Reviewable:end -->
@KiChjang
Copy link
Member Author

@KiChjang KiChjang commented Apr 12, 2016

This issue still isn't complete yet; #10505 added the necessary WebIDL bindings, but did not update parse_plain_attribute. There are also different behaviours and default values when setting/getting these attributes.

Given the new scope of the issue, I will instead investigate and work more on this.
@KiChjang KiChjang self-assigned this Apr 12, 2016
@KiChjang KiChjang removed the E-easy label Apr 12, 2016
@amarant
Copy link
Contributor

@amarant amarant commented Apr 12, 2016

Ok, thanks for the help.
@KiChjang KiChjang mentioned this issue May 2, 2016
Merged
bors-servo added a commit that referenced this issue May 24, 2016
@bors-servo
Auto merge of #10962 - KiChjang:input-attr-parse, r=asajeffrey
ac1e4ca 
Parse HTMLInputElement attributes

Fixes #10491.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10962)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue May 24, 2016
@bors-servo
Auto merge of #10962 - KiChjang:input-attr-parse, r=asajeffrey
Loading status checks…
8c4929a 
Parse HTMLInputElement attributes

Fixes #10491.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10962)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KiChjang KiChjang

Labels
A-content/dom C-assigned I-enhancement
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@amarant @KiChjang
You can’t perform that action at this time.