Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upConvert non-leaf inline boxes into SpacerBox or remove them #105
Labels
Comments
|
This may no longer be relevant. The last reference to I believe this was replaced with the function
That function doesn't handle padding, margins or borders yet but has a TODO comment to implement it. The following issues address the missing functionality: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Inline elements such as span with text node children make
GenericBoxes, which get put into inline flows' list of inline boxes.If these generic boxes don't actually induce any content for the purposes of inline flow (i.e., padding/borders left and right), then they should be elided. If they do use up space, then they should be "evolve" into one or two
SpacerBoxes that participate in the inline flow.This conversion could be put into the
TextRunScanner, or possibly even earlier during initial box creation. (this would drastically reduce the number ofGenericBoxes that are allocated and summarily destroyed)We'll eventually need to decide how
SpacerBoxes can be affected by line breaking relative to the content that they wrap.Tasks
SpacerBoxenum variantRenderBox::create_inline_spacer_for_side(box.rs)