Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTMLElement::Offset{Parent,Left,Right} should call HTMLBodyElement::is_the_html_body_element #10520

Open
frewsxcv opened this issue Apr 11, 2016 · 3 comments

Comments

@frewsxcv
Copy link
Member Author

@frewsxcv frewsxcv commented Apr 11, 2016

Ideally there'd be a regression test for this, but I don't know how difficult that would be to write.

frewsxcv added a commit to frewsxcv/servo that referenced this issue Oct 9, 2016
bors-servo added a commit that referenced this issue Oct 9, 2016
HTMLElement::Offset{Parent,Left,Right} should call is_the_html_body_element.

Fixes #10520.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13659)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Oct 9, 2016
HTMLElement::Offset{Parent,Left,Right} should call is_the_html_body_element.

Fixes #10520.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13659)
<!-- Reviewable:end -->
frewsxcv added a commit to frewsxcv/servo that referenced this issue Nov 4, 2016
bors-servo added a commit that referenced this issue Jan 19, 2017
HTMLElement::Offset{Parent,Left,Right} should call is_the_html_body_element.

Fixes #10520.

<!-- Reviewable:start -->

---

This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13659)

<!-- Reviewable:end -->
@jdm
Copy link
Member

@jdm jdm commented Jan 27, 2017

There's a solution in #13659; it's just missing a regression test and needs to be rebased.

@nox
Copy link
Member

@nox nox commented Oct 1, 2017

Still to be done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.