Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fetch CORS cache match for credentials is incorrect #10525

Closed
jdm opened this issue Apr 11, 2016 · 1 comment
Closed

Fetch CORS cache match for credentials is incorrect #10525

jdm opened this issue Apr 11, 2016 · 1 comment
Labels
A-network I-wrong An incorrect behaviour is observed.

Comments

@jdm
Copy link
Member

jdm commented Apr 11, 2016

As far as I can tell, the implementation of the cache match concept is here. This doesn't handle the "either credentials is false and request's credentials mode is not "include" or credentials is true" text properly.
@jdm jdm added I-wrong An incorrect behaviour is observed. A-network labels Apr 11, 2016
@dlrobertson
Copy link
Contributor

Looks interesting! I don't know much about CORS, but I should have a PR in soon

@dlrobertson dlrobertson mentioned this issue Apr 27, 2016
Merged
bors-servo pushed a commit that referenced this issue Apr 28, 2016
Auto merge of #10867 - danlrobertson:sandbox, r=KiChjang
3d38a60 
Fix logic for cors cache match

The current logic for a cors cache match does not consider "credentials is false and request's credentials mode is not "include" or credentials is true."

I could have missed something, but `CacheRequestDetails::credentials` is set to true if credentials mode is "include", and false otherwise. So `(!cors_cache.credentials && !cors_req.credentials) || cors_cache.credentials` would be directly following the spec, but unless I'm mistaken `cors_cache.credentials || !cors_req.credentials` is logically the same.

Fixes: #10525

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10867)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-network I-wrong An incorrect behaviour is observed.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jdm @dlrobertson