Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

position: absolute and overflow: hidden don't respect fixed positioning #10526

Closed
pcwalton opened this issue Apr 11, 2016 · 2 comments
Closed

position: absolute and overflow: hidden don't respect fixed positioning #10526

pcwalton opened this issue Apr 11, 2016 · 2 comments
Labels
A-gfx/compositing A-layout/uncategorized A-webrender I-wrong

Comments

@pcwalton
Copy link
Contributor

@pcwalton pcwalton commented Apr 11, 2016

In this document, "Home" should be fixed position, but isn't in Servo.

<!DOCTYPE html>
<body style="height: 2000px; background: linear-gradient(to bottom, white, black)">
<div style="position: fixed; top: 0; right: 0; left: 0;">
    <div style="position: absolute; left: 0; right: 0; height: 40px; overflow: hidden;">Home</div>
</div>

This breaks YouTube and the Washington Post, just to name two sites.
@pcwalton
Copy link
Contributor Author

@pcwalton pcwalton commented Apr 11, 2016

This only breaks in WebRender, oddly.
@pcwalton
Copy link
Contributor Author

@pcwalton pcwalton commented Apr 11, 2016

I have a fix for this.
pcwalton added a commit to pcwalton/servo that referenced this issue Apr 11, 2016
@pcwalton
layout: Make child stacking contexts of fixed position stacking contexts
8cc3e06 
also fixed position.

Improves YouTube.
Improves the Washington Post.

Closes servo#10526.
@pcwalton pcwalton mentioned this issue Apr 11, 2016
Merged
bors-servo added a commit that referenced this issue Apr 12, 2016
@bors-servo
Auto merge of #10529 - pcwalton:nested-fixed-position-webrender, r=gl…
Loading status checks…
fb4e0ae 
…ennw

layout: Make child stacking contexts of fixed position stacking contexts also fixed position.

Improves YouTube.
Improves the Washington Post.

Closes #10526.

r? @glennw

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10529)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Apr 12, 2016
@bors-servo
Auto merge of #10529 - pcwalton:nested-fixed-position-webrender, r=gl…
Loading status checks…
1503385 
…ennw

layout: Make child stacking contexts of fixed position stacking contexts also fixed position.

Improves YouTube.
Improves the Washington Post.

Closes #10526.

r? @glennw

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10529)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-gfx/compositing A-layout/uncategorized A-webrender I-wrong
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@pcwalton @frewsxcv
You can’t perform that action at this time.