Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reddit.com rendering regression #10571

Closed
paulrouget opened this issue Apr 13, 2016 · 8 comments
Closed

reddit.com rendering regression #10571

paulrouget opened this issue Apr 13, 2016 · 8 comments
Labels
C-has-manual-testcase

Comments

@paulrouget
Copy link
Contributor

@paulrouget paulrouget commented Apr 13, 2016

Reddit use to render more or less ok, but now, all the text is gone.

screen shot 2016-04-13 at 18 00 32
@metajack
Copy link
Contributor

@metajack metajack commented May 4, 2016

cc @pcwalton
I noticed this last week as well. Also, this site takes minutes to load, and the progress bar in browserhtml never completed. I got quite a few webrender exceeding its draw budget (70ms!) while the whole page was still white except for the progress bar. Once the page drew something like in paul's screenshot, I started getting RROR:js::rust: Error at https://www.redditmedia.com/ads/display/300x250#{"keywords": ["s.frontpage", "s.loggedout", "s.sfw"], "origin": "https://www.reddit.com"}:6:1: window.parent.frames[frame] is undefined in a loop.
@paulrouget
Copy link
Contributor Author

@paulrouget paulrouget commented May 4, 2016

(Make sure to run browserhtml with these parameters http://localhost:6060/index.html?progressbar=standalone&raf=timer to work around some known progressbar issues)
@pcwalton
Copy link
Contributor

@pcwalton pcwalton commented May 4, 2016

@metajack Let's keep the network issues and WR rendering issues in separate bugs. I suspect the network issues are just speculative HTML parsing as usual. This bug should be about the text only.
@metajack
Copy link
Contributor

@metajack metajack commented May 4, 2016

@pcwalton opened #11008 and #11009 for those.
@pcwalton
Copy link
Contributor

@pcwalton pcwalton commented May 10, 2016

Blocking: #10903
@pcwalton
Copy link
Contributor

@pcwalton pcwalton commented May 10, 2016

Minimal test case:

<!DOCTYPE html>
<style>
div {
    float: right;
    width: 300px;
    height: 15px;
    background: green;
}
section {
    margin-right: 300px;
    overflow: hidden;
    height: 80px;
    background: blue;
}
</style>
<div></div>
<section></section>

Pretty embarrassing that we don't have tests for this!
pcwalton added a commit to pcwalton/servo that referenced this issue May 11, 2016
@pcwalton
layout: Take margins in the inline direction into account when
b6bed34 
guessing the inline-size of block formatting contexts.

Fixes the layout on reddit.com.

Partially addresses servo#10571.
@pcwalton pcwalton mentioned this issue May 11, 2016
Merged
bors-servo added a commit that referenced this issue May 11, 2016
@bors-servo
Auto merge of #11125 - pcwalton:reddit-block-formatting-context-fix, …
105912b 
…r=<try>

layout: Take margins in the inline direction into account when guessing the inline-size of block formatting contexts.

Fixes the layout on reddit.com.

Partially addresses #10571.

r? @mbrubeck

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11125)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue May 11, 2016
@bors-servo
Auto merge of #11125 - pcwalton:reddit-block-formatting-context-fix, …
00ad22c 
…r=mbrubeck

layout: Take margins in the inline direction into account when guessing the inline-size of block formatting contexts.

Fixes the layout on reddit.com.

Partially addresses #10571.

r? @mbrubeck

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11125)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue May 11, 2016
@bors-servo
Auto merge of #11125 - pcwalton:reddit-block-formatting-context-fix, …
Loading status checks…
9886374 
…r=mbrubeck

layout: Take margins in the inline direction into account when guessing the inline-size of block formatting contexts.

Fixes the layout on reddit.com.

Partially addresses #10571.

r? @mbrubeck

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11125)
<!-- Reviewable:end -->
@pcwalton
Copy link
Contributor

@pcwalton pcwalton commented May 11, 2016

This is basically fixed now by #11125, but I'm holding off on closing because there's a crash (#10903, has a patch) on Reddit still.
@paulrouget
Copy link
Contributor Author

@paulrouget paulrouget commented May 16, 2016

Both #11125 and #10903 are fixed now. Closing.
@paulrouget paulrouget closed this May 16, 2016
zakorgy added a commit to zakorgy/servo that referenced this issue May 26, 2016
@pcwalton @zakorgy
layout: Take margins in the inline direction into account when
4631cba 
guessing the inline-size of block formatting contexts.

Fixes the layout on reddit.com.

Partially addresses servo#10571.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-has-manual-testcase
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
@jdm @metajack @pcwalton @paulrouget
You can’t perform that action at this time.