Use the document base url when resolving form action URLs

[jdm]

According to the specification, we need to be using the base URL. This means calling document.base_url() instead of window.get_url() as the code currently does (specifically, make_url_or_base_getter, which is used for the action and formaction attributes in elements like HTMLFormElement).

Code: components/script/dom/macros.rs
Test:

<base href="resources/"></base>
<form action="target.html">

Visit this from a web server (eg. python -m SimpleHTTPServer) with a resources/ directory that contains a target.html file that isn't empty.

There does not appear to be an automated test for this yet, so we'll need to write a test! It belongs in tests/wpt/metadata/html/semantics/forms/the-form-element/. Specifically, it should have an iframe that contains a form with a base url, and the form should be submitted via JavaScript (form.submit()). The resulting page should notify the parent page that it was successful (window.parent.some_success_function()).

[mylainos]

I would like to take this one please.

[jdm]

Go ahead!

[mylainos]

So I need to add a .html in tests/wpt/web-platform-tests/html/semantics/forms/the-form-element/ and a .ini in tests/wpt/metadata/html/semantics/forms/the-form-element/ ?

[jdm]

There should be no need for the ini if the test passes. Those files are used for annotation test results that are anything besides PASS.

[mylainos]

I don't understand what should I put in some_success_function(). Is it something like that?

test(function(){
      assert_equals(...);
    }, ...);

Should I use this?

<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>

[jdm]

Assuming there is a var t = async_test(); in the global scope, this could work:

function some_success_function() {
    t.step_func_done();
}

[jdm]

@mylainos Are you still working on this? Any questions?

[mylainos]

@jdm I've a problem with the target of the form.

[jdm]

Most recent attempt to solve this in #11219, which had some comments that needed addressing in #11219 (comment).

[ducks]

I'll take a crack at this one, please

[jdm]

Please do! Ask questions about anything that's unclear!