Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finish hooking up the XML parser #10581

Closed
jdm opened this issue Apr 13, 2016 · 4 comments
Closed

Finish hooking up the XML parser #10581

jdm opened this issue Apr 13, 2016 · 4 comments
Labels
A-content/dom B-interesting-project C-assigned

Comments

@jdm
Copy link
Member

@jdm jdm commented Apr 13, 2016

#10371 was one attempt for this, but we don't think it was right (and no test changes were observed). We need to figure out what the missing pieces are at this point.
@jdm
Copy link
Member Author

@jdm jdm commented Apr 13, 2016

@ConnorGBrewster This would be a valuable task if you're interested.
This was referenced Apr 13, 2016
Closed
Closed
@cbrewster
Copy link
Member

@cbrewster cbrewster commented Apr 13, 2016

@jdm yeah I can work on this one!
@jdm
Copy link
Member Author

@jdm jdm commented Apr 13, 2016

The basic goal here is to ensure that documents that have an appropriate XML content type end up being treated as XML documents (see ScriptThread::load). It would be useful to figure out what's currently broken in tests/wpt/web-platform-tests/domparsing/DOMParser-parseFromString-xml.html, for example.
@KiChjang KiChjang added the C-assigned label Apr 13, 2016
@cbrewster cbrewster mentioned this issue Apr 16, 2016
Merged
bors-servo added a commit that referenced this issue Apr 27, 2016
@bors-servo
Auto merge of #10647 - ConnorGBrewster:parse_xml, r=jdm
Loading status checks…
4e36ed1 
Finish hooking up XML parser

This is a work in progress PR for #10581. I just want to make sure I am headed in the right direction.

cc @jdm

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10647)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Apr 27, 2016
@bors-servo
Auto merge of #10647 - ConnorGBrewster:parse_xml, r=jdm
Loading status checks…
0125892 
Finish hooking up XML parser

This is a work in progress PR for #10581. I just want to make sure I am headed in the right direction.

cc @jdm

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10647)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Apr 27, 2016
@bors-servo
Auto merge of #10647 - ConnorGBrewster:parse_xml, r=jdm
Loading status checks…
614cc6c 
Finish hooking up XML parser

This is a work in progress PR for #10581. I just want to make sure I am headed in the right direction.

cc @jdm

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10647)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Apr 27, 2016
@bors-servo
Auto merge of #10647 - ConnorGBrewster:parse_xml, r=jdm
Loading status checks…
daa1a2a 
Finish hooking up XML parser

This is a work in progress PR for #10581. I just want to make sure I am headed in the right direction.

cc @jdm

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10647)
<!-- Reviewable:end -->
@cbrewster
Copy link
Member

@cbrewster cbrewster commented Apr 29, 2016

Fixed in #10647
@KiChjang KiChjang closed this Apr 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-content/dom B-interesting-project C-assigned
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@jdm @KiChjang @cbrewster
You can’t perform that action at this time.