Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upCanvasRenderingContext2D currentColor support is broken #10601
Closed
Labels
Comments
|
I think I might be able to do this one. |
bors-servo
added a commit
that referenced
this issue
Apr 17, 2016
Setting current color to black if canvas is not rendered in document Fixes #10601 The change seems deceptively easy, I hope I am not missing anything... <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10651) <!-- Reviewable:end -->
bors-servo
added a commit
that referenced
this issue
Apr 22, 2016
Setting current color to black if canvas is not rendered in document Fixes #10601 The change seems deceptively easy, I hope I am not missing anything... <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10651) <!-- Reviewable:end -->
bors-servo
added a commit
that referenced
this issue
Apr 22, 2016
Setting current color to black if canvas is not rendered in document Fixes #10601 The change seems deceptively easy, I hope I am not missing anything... <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10651) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Blocks #10597.
At least for the not-rendered case.
style.GetPropertyValue(DOMString::from("color"))returns the empty string, and parsing that fails.components/script/dom/canvasrenderingcontext2d.rs.2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.current.removed.html.