Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upDifferentiate between associated windows and real document views #1073
Comments
|
@bholley probably has thoughts on how we deal with JSContexts. As for the scope, we might want a more general global object rather than requiring a Window (so we don't have to rewrite everything for workers). |
|
The JSContext should live on the runtime. JSContexts are going away soon in SM. Conceptually, they should be 1-to-1 with JSRuntimes in servo. |
|
We've got code right now that sets the private field of a JSContext to a pointer to the associated Page right now, so that will need some consideration in the presence of iframes and such. |
|
OMGNO! We should not be doing that. I've been working on getting rid of that nonsense from Gecko for over a year now. How easy is it to rip out? What do we need it for? |
|
http://mxr.mozilla.org/servo/search?string=page_from_context |
|
The great JSContext scare is behind us, and they're 1:1 with runtimes. |
Nit/style clean-up for first round of merged TTWF Seoul PRs merges.
|
Related: #4806 |
|
Fixed in #9603. |
#1072 is getting rid of optional windows, since we require them in order to access the JSContext everywhere. However, a newly parsed Document obtained via DOMParser should have a null defaultView, so we need a way to reflect that.