Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign up`find_utf16_code_unit_offset` ignores `-Z replace-surrogates` #10780
Labels
Comments
SimonSapin
added a commit
that referenced
this issue
Apr 21, 2016
SimonSapin
added a commit
that referenced
this issue
May 24, 2016
bors-servo
added a commit
that referenced
this issue
May 24, 2016
Make /dom/nodes/CharacterData-surrogates.html not panic. It now fails since `DOMString` is currently based on `std::string::String` on the Rust side, which is strictly well-formed UTF-8 and can not contain unpaired surrogate code points. Fixes #10780 r? @Ms2ger <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10796) <!-- Reviewable:end -->
bors-servo
added a commit
that referenced
this issue
May 24, 2016
Make /dom/nodes/CharacterData-surrogates.html not panic. It now fails since `DOMString` is currently based on `std::string::String` on the Rust side, which is strictly well-formed UTF-8 and can not contain unpaired surrogate code points. Fixes #10780 r? @Ms2ger <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10796) <!-- Reviewable:end -->
bors-servo
added a commit
that referenced
this issue
May 24, 2016
Make /dom/nodes/CharacterData-surrogates.html not panic. It now fails since `DOMString` is currently based on `std::string::String` on the Rust side, which is strictly well-formed UTF-8 and can not contain unpaired surrogate code points. Fixes #10780 r? @Ms2ger <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10796) <!-- Reviewable:end -->
bors-servo
added a commit
that referenced
this issue
May 24, 2016
Make /dom/nodes/CharacterData-surrogates.html not panic. It now fails since `DOMString` is currently based on `std::string::String` on the Rust side, which is strictly well-formed UTF-8 and can not contain unpaired surrogate code points. Fixes #10780 r? @Ms2ger <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10796) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This makes
/dom/nodes/CharacterData-surrogates.htmlcrash.@SimonSapin you've got blame here.