Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove panic! from compositor #10864

Closed
asajeffrey opened this issue Apr 26, 2016 · 2 comments
Closed

Remove panic! from compositor #10864

asajeffrey opened this issue Apr 26, 2016 · 2 comments
Assignees
@asajeffrey
Labels
A-constellation I-enhancement I-panic

Comments

@asajeffrey
Copy link
Member

@asajeffrey asajeffrey commented Apr 26, 2016

We got rid of the uses of .unwrap() but not panic!.
@asajeffrey asajeffrey self-assigned this Apr 26, 2016
@asajeffrey asajeffrey added the I-panic label Apr 26, 2016
@aneeshusa
Copy link
Member

@aneeshusa aneeshusa commented Apr 26, 2016

Should we add a lint for this to the etc/ci/check_no_unwrap.sh script as well?
@asajeffrey
Copy link
Member Author

@asajeffrey asajeffrey commented Apr 26, 2016

That would be a good idea.
@asajeffrey asajeffrey mentioned this issue Apr 28, 2016
Merged
bors-servo added a commit that referenced this issue Apr 30, 2016
@bors-servo
Auto merge of #10902 - asajeffrey:remove-explicit-panic-from-composit…
Loading status checks…
f75fa52 
…or, r=aneeshusa

Remove panic! from the compositor

Fixes #10864, and adds a check to `/etc/ci/check_no_unwrap.sh`.

r? @aneeshusa

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10902)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@asajeffrey asajeffrey

Labels
A-constellation I-enhancement I-panic
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@asajeffrey @aneeshusa @wafflespeanut
You can’t perform that action at this time.