Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename check_no_unwrap.sh to check_no_panic.sh #10930

Closed
aneeshusa opened this issue Apr 29, 2016 · 3 comments
Closed

Rename check_no_unwrap.sh to check_no_panic.sh #10930

aneeshusa opened this issue Apr 29, 2016 · 3 comments
Labels
A-testing C-assigned C-has open PR

Comments

@aneeshusa
Copy link
Member

@aneeshusa aneeshusa commented Apr 29, 2016

The etc/ci/check_no_unwrap.sh script checks that we don't call unwrap(), but after #10902 will also check for panic!(). It should be renamed to etc/ci/check_no_panic.sh to reflect the expanded scope.

We'll also need to update the etc/ci/buildbot_steps.yml file.

Blocked on servo/saltfs#316, #10902.
@aneeshusa aneeshusa added the E-easy label Apr 29, 2016
@6br 6br mentioned this issue Apr 30, 2016
Merged
@notriddle notriddle added the A-testing label May 1, 2016
@jdm jdm added the C-assigned label May 2, 2016
@zeusintuivo
Copy link
Contributor

@zeusintuivo zeusintuivo commented Jul 4, 2016

Is this solved or repeated, ...confusing.
@jdm
Copy link
Member

@jdm jdm commented Jul 4, 2016

It's not solved yet, since the PR to address it is blocked on changes being made in another repository.
@zeusintuivo
Copy link
Contributor

@zeusintuivo zeusintuivo commented Jul 6, 2016

I have made a feature fix for it here just in case
https://github.com/zeusintuivo/servo/tree/feature/10930
@zeusintuivo zeusintuivo mentioned this issue Jul 11, 2016
Closed
7 of 7 tasks complete
@Ms2ger Ms2ger removed the E-easy label Jul 13, 2016
bors-servo added a commit that referenced this issue Oct 29, 2016
@bors-servo
Auto merge of #10942 - 6br:rename_check_no_panic, r=aneeshusa
Loading status checks…
3ae0a33 
Rename check_no_unwrap.sh to check_no_panic.sh

Hello, I fixed #10930.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10942)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-testing C-assigned C-has open PR
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Rename check_no_unwrap.sh to check_no_panic.sh
Rename check_no_unwrap.sh to check_no_panic.sh
5 participants
@jdm @Ms2ger @notriddle @aneeshusa @zeusintuivo
You can’t perform that action at this time.