Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass in string lengths to Gecko_GetAttrAsUTF8. #11043

Merged
merged 1 commit into from May 6, 2016
Merged

Pass in string lengths to Gecko_GetAttrAsUTF8. #11043

merged 1 commit into from May 6, 2016

Conversation

heycam
Copy link
Contributor

@heycam heycam commented May 6, 2016 •
edited by larsbergstrom

This change is Reviewable

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label May 6, 2016
@heycam
Copy link
Contributor Author

heycam commented May 6, 2016

Gecko-side updates are https://bugzilla.mozilla.org/show_bug.cgi?id=1270696.

@heycam
Copy link
Contributor Author

heycam commented May 6, 2016

r? @bholley

@highfive highfive assigned bholley and unassigned pcwalton May 6, 2016
@bholley
Copy link
Contributor

bholley commented May 6, 2016

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit 603a199 has been approved by bholley

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels May 6, 2016
@bors-servo
Copy link
Contributor

⌛ Testing commit 603a199 with merge 0558687...

bors-servo pushed a commit that referenced this pull request May 6, 2016
Auto merge of #11043 - heycam:attr, r=bholley
0558687 
Pass in string lengths to Gecko_GetAttrAsUTF8.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11043)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows

@bors-servo bors-servo merged commit 603a199 into servo:master May 6, 2016
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label May 6, 2016
@heycam heycam deleted the attr branch May 25, 2016 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bholley bholley

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@heycam @bholley @bors-servo @pcwalton @highfive