Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move trait ConvertPipelineIdToWebRender to a better place #11084

Merged
merged 1 commit into from May 9, 2016
Merged

move trait ConvertPipelineIdToWebRender to a better place #11084

merged 1 commit into from May 9, 2016

Conversation

kevgs
Copy link
Contributor

@kevgs kevgs commented May 8, 2016 •
edited by larsbergstrom

This change is Reviewable

@highfive
Copy link

highfive commented May 8, 2016

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @nox (or someone else) soon.

@highfive
Copy link

highfive commented May 8, 2016

warning Warning warning

  • These commits modify layout code, but no tests are modified.Please consider adding a test!

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label May 8, 2016
@kevgs kevgs mentioned this pull request May 8, 2016
Closed
@Ms2ger
Copy link
Contributor

Ms2ger commented May 9, 2016

@bors-servo r+

Thanks!

@bors-servo
Copy link
Contributor

📌 Commit 8b6a609 has been approved by Ms2ger

@highfive highfive assigned Ms2ger and unassigned nox May 9, 2016
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels May 9, 2016
@Ms2ger Ms2ger mentioned this pull request May 9, 2016
Merged
@bors-servo
Copy link
Contributor

⌛ Testing commit 8b6a609 with merge 9a8c817...

bors-servo pushed a commit that referenced this pull request May 9, 2016
Auto merge of #11084 - kevgs:layout_traits, r=Ms2ger
9a8c817 
move trait ConvertPipelineIdToWebRender to a better place

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11084)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows

@bors-servo bors-servo merged commit 8b6a609 into servo:master May 9, 2016
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label May 9, 2016
@kevgs kevgs deleted the layout_traits branch May 9, 2016 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Ms2ger Ms2ger

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@kevgs @highfive @Ms2ger @bors-servo @nox