Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

duckduckgo.com doesn't scroll #11150

Closed
paulrouget opened this issue May 12, 2016 · 3 comments
Closed

duckduckgo.com doesn't scroll #11150

paulrouget opened this issue May 12, 2016 · 3 comments
Assignees
Labels

Comments

@paulrouget
Copy link
Contributor

@paulrouget paulrouget commented May 12, 2016

STR:

@paulrouget
Copy link
Contributor Author

@paulrouget paulrouget commented May 12, 2016

Might be related: #11151

pcwalton added a commit to pcwalton/webrender that referenced this issue May 20, 2016
Further work should expand this to an entire rectangle/transform stack,
but this is an improvement over the current situation.

This was necessary to properly handle clipping in the presence of
nested iframes and `overflow: scroll` stacking contexts, while
simultaneously handling transformed and clipped iframes.

We still have some clipping issues when `overflow: scroll`, iframes, and
transforms are all nested together: this is visible in the browser.html
tab change animation on duckduckgo.com result pages. I wanted to get
this in now, though, because this significantly improves the current
situation.

Addresses servo/servo#11150.
Addresses servo/servo#11151.
@nox nox added the C-assigned label May 23, 2016
bors-servo added a commit to servo/webrender that referenced this issue May 23, 2016
Expand viewports to consist of a rectangle and a transform.

Further work should expand this to an entire rectangle/transform stack,
but this is an improvement over the current situation.

This was necessary to properly handle clipping in the presence of
nested iframes and `overflow: scroll` stacking contexts, while
simultaneously handling transformed and clipped iframes.

We still have some clipping issues when `overflow: scroll`, iframes, and
transforms are all nested together: this is visible in the browser.html
tab change animation on duckduckgo.com result pages. I wanted to get
this in now, though, because this significantly improves the current
situation.

Addresses servo/servo#11150.
Addresses servo/servo#11151.

r? @glennw
bors-servo added a commit to servo/webrender that referenced this issue May 23, 2016
Expand viewports to consist of a rectangle and a transform.

Further work should expand this to an entire rectangle/transform stack,
but this is an improvement over the current situation.

This was necessary to properly handle clipping in the presence of
nested iframes and `overflow: scroll` stacking contexts, while
simultaneously handling transformed and clipped iframes.

We still have some clipping issues when `overflow: scroll`, iframes, and
transforms are all nested together: this is visible in the browser.html
tab change animation on duckduckgo.com result pages. I wanted to get
this in now, though, because this significantly improves the current
situation.

Addresses servo/servo#11150.
Addresses servo/servo#11151.

r? @glennw
@paulrouget
Copy link
Contributor Author

@paulrouget paulrouget commented May 24, 2016

This is now fixed.

@paulrouget paulrouget closed this May 24, 2016
pcwalton added a commit to pcwalton/servo that referenced this issue May 24, 2016
bors-servo added a commit that referenced this issue May 25, 2016
Update WebRender.

Picks up fixes for #11150, #11151, #11323, and #11327.

r? @mbrubeck

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11379)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue May 25, 2016
Update WebRender.

Picks up fixes for #11150, #11151, #11323, and #11327.

r? @mbrubeck

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11379)
<!-- Reviewable:end -->
@atouchet
Copy link
Contributor

@atouchet atouchet commented Oct 28, 2017

I am experiencing this issue again. I'm not sure if this is another case of #18769 or something different.

Edit: Scrolling is working now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.