Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iframe doesn't clip its content anymore #11151

Closed
paulrouget opened this issue May 12, 2016 · 6 comments
Closed

iframe doesn't clip its content anymore #11151

paulrouget opened this issue May 12, 2016 · 6 comments
Assignees
@pcwalton
Labels
C-assigned C-has-manual-testcase

Comments

@paulrouget
Copy link
Contributor

@paulrouget paulrouget commented May 12, 2016

This breaks browserhtml (can't scroll, overflowing content visible when zooming out, chrome buttons are covered by content).

<style>
  iframe {
    display: block;
    width: 500px;
    height: 500px;
    border: 2px solid green;
  }
</style>
<iframe src="http://duckduckgo.com/?q=foobar"></iframe>

screen shot 2016-05-12 at 09 34 52
This was referenced May 12, 2016
Open
Closed
Closed
@paulrouget
Copy link
Contributor Author

@paulrouget paulrouget commented May 12, 2016

Might be related: #11150
@paulrouget paulrouget mentioned this issue May 12, 2016
Closed
@paulrouget
Copy link
Contributor Author

@paulrouget paulrouget commented May 16, 2016

/cc @glennw @pcwalton
@pcwalton
Copy link
Contributor

@pcwalton pcwalton commented May 16, 2016

More minimal test case:

<style>
  iframe {
    display: block;
    width: 500px;
    height: 500px;
    border: 2px solid green;
  }
</style>
<iframe src="data:text/html,<body style='overflow: hidden; overflow-y: auto;'><div style='background: blue; height: 2000px'>"></iframe>
@pcwalton
Copy link
Contributor

@pcwalton pcwalton commented May 17, 2016

Regression started with overflow: scroll support: #10717
pcwalton added a commit to pcwalton/webrender that referenced this issue May 20, 2016
@pcwalton
Expand viewports to consist of a rectangle and a transform.
1b68948 
Further work should expand this to an entire rectangle/transform stack,
but this is an improvement over the current situation.

This was necessary to properly handle clipping in the presence of
nested iframes and `overflow: scroll` stacking contexts, while
simultaneously handling transformed and clipped iframes.

We still have some clipping issues when `overflow: scroll`, iframes, and
transforms are all nested together: this is visible in the browser.html
tab change animation on duckduckgo.com result pages. I wanted to get
this in now, though, because this significantly improves the current
situation.

Addresses servo/servo#11150.
Addresses servo/servo#11151.
@pcwalton pcwalton mentioned this issue May 20, 2016
Merged
@nox nox added the C-assigned label May 23, 2016
bors-servo added a commit to servo/webrender that referenced this issue May 23, 2016
@bors-servo
Auto merge of #274 - pcwalton:viewport-reform, r=glennw
Loading status checks…
dfc28be 
Expand viewports to consist of a rectangle and a transform.

Further work should expand this to an entire rectangle/transform stack,
but this is an improvement over the current situation.

This was necessary to properly handle clipping in the presence of
nested iframes and `overflow: scroll` stacking contexts, while
simultaneously handling transformed and clipped iframes.

We still have some clipping issues when `overflow: scroll`, iframes, and
transforms are all nested together: this is visible in the browser.html
tab change animation on duckduckgo.com result pages. I wanted to get
this in now, though, because this significantly improves the current
situation.

Addresses servo/servo#11150.
Addresses servo/servo#11151.

r? @glennw
bors-servo added a commit to servo/webrender that referenced this issue May 23, 2016
@bors-servo
Auto merge of #274 - pcwalton:viewport-reform, r=glennw
Loading status checks…
7f7dd3f 
Expand viewports to consist of a rectangle and a transform.

Further work should expand this to an entire rectangle/transform stack,
but this is an improvement over the current situation.

This was necessary to properly handle clipping in the presence of
nested iframes and `overflow: scroll` stacking contexts, while
simultaneously handling transformed and clipped iframes.

We still have some clipping issues when `overflow: scroll`, iframes, and
transforms are all nested together: this is visible in the browser.html
tab change animation on duckduckgo.com result pages. I wanted to get
this in now, though, because this significantly improves the current
situation.

Addresses servo/servo#11150.
Addresses servo/servo#11151.

r? @glennw
@paulrouget
Copy link
Contributor Author

@paulrouget paulrouget commented May 24, 2016

This is now fixed. But in browser.html, the iframe is not clipped when zoomed out. I'll file a different issue.
@paulrouget paulrouget closed this May 24, 2016
@paulrouget paulrouget mentioned this issue May 24, 2016
Closed
@paulrouget
Copy link
Contributor Author

@paulrouget paulrouget commented May 24, 2016

Follow up: #11358
pcwalton added a commit to pcwalton/servo that referenced this issue May 24, 2016
@pcwalton
Update WebRender.
4e329f5 
Picks up fixes for servo#11150, servo#11151, servo#11323, and servo#11327.
@pcwalton pcwalton mentioned this issue May 24, 2016
Merged
bors-servo added a commit that referenced this issue May 25, 2016
@bors-servo
Auto merge of #11379 - pcwalton:wrup4, r=mbrubeck
0341191 
Update WebRender.

Picks up fixes for #11150, #11151, #11323, and #11327.

r? @mbrubeck

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11379)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue May 25, 2016
@bors-servo
Auto merge of #11379 - pcwalton:wrup4, r=mbrubeck
Loading status checks…
72ffe34 
Update WebRender.

Picks up fixes for #11150, #11151, #11323, and #11327.

r? @mbrubeck

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11379)
<!-- Reviewable:end -->
@paulrouget paulrouget mentioned this issue Jun 7, 2016
Closed
@paulrouget paulrouget mentioned this issue Jun 30, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pcwalton pcwalton

Labels
C-assigned C-has-manual-testcase
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
@jdm @nox @pcwalton @paulrouget
You can’t perform that action at this time.