Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compositing should not depend on num-traits #11198

Closed
Ms2ger opened this issue May 16, 2016 · 3 comments
Closed

compositing should not depend on num-traits #11198

Ms2ger opened this issue May 16, 2016 · 3 comments
Labels
C-assigned E-easy I-refactor

Comments

@Ms2ger
Copy link
Contributor

@Ms2ger Ms2ger commented May 16, 2016

The extern crate was removed in #11192; we also need to remove the dependency in components/compositing/Cargo.toml.
@jdm
Copy link
Member

@jdm jdm commented May 16, 2016

After making this change, run ./mach cargo-update -p compositing to ensure all the Cargo.lock files are updated.
@canova
Copy link
Member

@canova canova commented May 16, 2016

I would like to take this.
@jdm
Copy link
Member

@jdm jdm commented May 16, 2016

Please do!
@jdm jdm added the C-assigned label May 16, 2016
@canova canova mentioned this issue May 16, 2016
Merged
4 of 5 tasks complete
bors-servo added a commit that referenced this issue May 16, 2016
@bors-servo
Auto merge of #11213 - canaltinova:compositing, r=mbrubeck
8cda146 
Remove num-traits from compositing

Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data:
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy --faster` does not report any errors
- [X] These changes fix #11198 (github issue number if applicable).

Either:
- [ ] There are tests for these changes OR
- [X] These changes do not require tests

Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11213)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue May 17, 2016
@bors-servo
Auto merge of #11213 - canaltinova:compositing, r=mbrubeck
Loading status checks…
fe4061e 
Remove num-traits from compositing

Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data:
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy --faster` does not report any errors
- [X] These changes fix #11198 (github issue number if applicable).

Either:
- [ ] There are tests for these changes OR
- [X] These changes do not require tests

Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11213)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-assigned E-easy I-refactor
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Remove num-traits from compositing
3 participants
@jdm @Ms2ger @canova
You can’t perform that action at this time.