Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build system should warn if wrong version of rustc installed #112

Closed
burg opened this issue Oct 13, 2012 · 2 comments
Closed

Build system should warn if wrong version of rustc installed #112

burg opened this issue Oct 13, 2012 · 2 comments

Comments

@burg
Copy link

@burg burg commented Oct 13, 2012

To reduce confusion and accidental bug reports, the Makefile should compare a stored rust commit hash against the rustc actually used. If it differs, print out an all-caps warning.

This will require putting a submodule-like hash somewhere in the tree.

@JamieKnight
Copy link
Contributor

@JamieKnight JamieKnight commented Apr 17, 2013

The linked ticked #132 is marked as closed. does it make sense for this ticket to still be open?

@metajack
Copy link
Contributor

@metajack metajack commented Apr 17, 2013

I think this is no longer an issue since we now ship rust with servo.

@metajack metajack closed this Apr 17, 2013
ChrisParis pushed a commit to ChrisParis/servo that referenced this issue Sep 7, 2014
glennw added a commit to glennw/servo that referenced this issue Jan 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.